Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient][WebProfilerBundle] Do not generate cURL command when files are uploaded#52472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromMatTheCat:ticket_51366
Nov 6, 2023

Conversation

MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedNov 6, 2023•
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#51366
LicenseMIT

I also removed@requires extension openssl annotations since that does not seem to be the case since#45729.

Failures in AppVeyor occur because double quotes are missing around--data-raw values. Possibly related to#52429.

@nicolas-grekas
Copy link
Member

Up to fix the quote issue in the same PR for tests?

@MatTheCat
Copy link
ContributorAuthor

@nicolas-grekas I'm not sure what should be done regarding these double quotes since it seems to be Windows-specific 🤔

@nicolas-grekas
Copy link
Member

I think we should just adjust the expected output depending on Windows or not. Failing tests should pass.

@nicolas-grekas
Copy link
Member

Or maybe@alexandre-daubois can provide the fix for the tests?

@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commitb8bba36 intosymfony:6.3Nov 6, 2023
@MatTheCatMatTheCat deleted the ticket_51366 branchNovember 6, 2023 17:59
@MatTheCat
Copy link
ContributorAuthor

I'll look into it tomorrow if@alexandre-daubois hasn't in the meantime.

nicolas-grekas reacted with heart emoji

@alexandre-daubois
Copy link
Member

alexandre-daubois commentedNov 6, 2023•
edited
Loading

Thank you for proposing your help Mathieu! Trying to understand what I missed in my PR 😄

@MatTheCat
Copy link
ContributorAuthor

From what I saw (did not investigate further),HttpClientDataCollector::escapePayload returns different strings whether on Unix or Windows, butHttpClientDataCollector::provideCurlRequests expects the Unix return. That would explain why passing tests fail on AppVeyor.

nicolas-grekas added a commit that referenced this pull requestNov 7, 2023
…-daubois)This PR was merged into the 6.3 branch.Discussion----------[HttpKernel] Fix quotes expectations in tests| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITFollowing#52472 (comment)On Windows, quotes are only added when necessary. This means that for a value like `foobar`, no quotes are added. I updated the test so the first dataset shows the escaping whereas the second updated dataset shows that it is expected that no quotes are added around data.Commits-------dcc465f [HttpKernel] Fix quotes expectations in tests
This was referencedNov 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

4 participants
@MatTheCat@nicolas-grekas@alexandre-daubois@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp