Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Cache][HttpFoundation][Lock] Fix empty username/password for PDO PostgreSQL#52457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:fix-pdo-postgres-default-username-and-passwordNov 6, 2023
Merged
[Cache][HttpFoundation][Lock] Fix empty username/password for PDO PostgreSQL#52457
nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:fix-pdo-postgres-default-username-and-passwordNov 6, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Don't know if I should ignore fabbot. Even though the default property values are useless on 5.4, they are required on 6.x because of the type hints. |
fabpot added a commit that referenced this pull requestNov 5, 2023
This PR was merged into the 6.4 branch.Discussion----------[Cache] Fix property types in PdoAdapter| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITI've noticed this while working on#52457, there's no reason these properties should be mixed as far as I can tell.Commits-------f306b74 [Cache] Fix property types in PdoAdapter
5c67a6e to534c34cCompareThank you@HypeMC. |
This was referencedNov 10, 2023
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currentlypdo_pgsql has a bug where the username & password arguments have precedence over the DSN, even thoughtaccording to the docs it should be the other way. This was recently fixed on PHP's side, but itwon't be available till 8.4.
Since the bug is not present when the values passed are
null, which are the default argument values anyway, this PR changes the default values of the properties to match.