Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[TwigBridge] Mark CodeExtension as @internal#52449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Does marking this class For instance |
…nicolas-grekas)This PR was merged into the 7.0 branch.Discussion----------[WebProfilerBundle] Mark CodeExtension as non-internal| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITFrom#52449 (comment) by `@GromNaN`Using those twig helpers in a profiler page is 100% legit. I think that the notice in the class' docbloc + the fact it moved to the WebProfilerBundle namespace allows us to mark the class back as non-internal.Commits-------b1c437a [WebProfilerBundle] Mark CodeExtension as non-internal
…nicolas-grekas)This PR was merged into the 7.0 branch.Discussion----------[WebProfilerBundle] Mark CodeExtension as non-internal| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITFromsymfony/symfony#52449 (comment) by `@GromNaN`Using those twig helpers in a profiler page is 100% legit. I think that the notice in the class' docbloc + the fact it moved to the WebProfilerBundle namespace allows us to mark the class back as non-internal.Commits-------b1c437a759a [WebProfilerBundle] Mark CodeExtension as non-internal
This is really just internal code used by our own tools. Let's make it clear that nobody should use it in production.