NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Add option`separator` to`ChoiceType` to use a custom separator after preferred choices#52447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.1frommboultoureau:customize-choicetype-separator

Jan 9, 2024

Merged

[Form] Add option`separator` to`ChoiceType` to use a custom separator after preferred choices#52447

nicolas-grekas merged 1 commit intosymfony:7.1frommboultoureau:customize-choicetype-separator

Jan 9, 2024

Conversation

Copy link

Contributor

mboultoureau commentedNov 3, 2023•
edited by OskarStark
Loading

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Linked with#52260
License	MIT

Addseparator_html option to display theseparator text as HTML

mboultoureau requested review fromxabbuh andyceruto ascode owners

November 3, 2023 21:05

carsonbot added Status: Needs Review Feature Form labels

Nov 3, 2023

carsonbot added this to the6.4 milestone

Nov 3, 2023

Copy link

carsonbot commentedNov 3, 2023

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link

ContributorAuthor

mboultoureau commentedNov 3, 2023

Theseparator option is only available in the Twig template, so I've kept this behavior for this new option. Should I add them so that they're both accessible from the form builder to maintain consistency (likelabel /label_html andhelp /help_html)?

xabbuh requested changes

Nov 4, 2023

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO this should indeed be a „real“ form type option.

src/Symfony/Component/Form/CHANGELOG.md OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Nov 4, 2023

xabbuh requested changes

Nov 6, 2023

View reviewed changes

src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twigShow resolvedHide resolved

nicolas-grekas modified the milestones:6.4,7.1

Nov 15, 2023

nicolas-grekas reviewed

Nov 20, 2023

View reviewed changes

src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Nov 20, 2023

View reviewed changes

src/Symfony/Bridge/Twig/Resources/views/Form/foundation_5_layout.html.twig OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

mboultoureau commentedDec 20, 2023•
edited
Loading

Approved corrections

mboultoureau requested a review fromxabbuh

December 20, 2023 09:14

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Dec 20, 2023

nicolas-grekas approved these changes

Dec 30, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 30, 2023

xabbuh approved these changes

Jan 5, 2024

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with a minor suggestion for the changelog

src/Symfony/Component/Form/CHANGELOG.md OutdatedShow resolvedHide resolved

nicolas-grekas changed the title~~[Form] Addseparator_html option to display theseparator text as HTML~~[Form] Add optionseparator toChoiceType to use a custom separator after preferred choices

Jan 9, 2024

nicolas-grekas approved these changes

Jan 9, 2024

View reviewed changes