NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Yaml] Fix uid binary parsing#52443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4frommRoca:fix/yaml-utf8-uid-parsing

Nov 5, 2023

Merged

[Yaml] Fix uid binary parsing#52443

fabpot merged 1 commit intosymfony:5.4frommRoca:fix/yaml-utf8-uid-parsing

Nov 5, 2023

Conversation

Copy link

Contributor

mRoca commentedNov 3, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Currently, on SF 5.4 & 6.4, a YAML file containing{ uid: !!binary Ju0Yh+uqSXOagJZFTlUt8g== } cannot be parsed because of apreg_match error:Malformed UTF-8 characters, possibly incorrectly encoded.

This is becausepreg_match should not be run over a binary string, but this specific binary string matches the following tests :\is_string($value) && '' !== $value && '&' === $value[0] (the string starts with0x26 , which is the UTF-8& char).

[Yaml] Fix uid binary parsing

ce3e282

mRoca requested a review fromxabbuh as acode owner

November 3, 2023 14:42

carsonbot added Status: Needs Review Bug Yaml labels

Nov 3, 2023

carsonbot added this to the5.4 milestone

Nov 3, 2023

Copy link

carsonbot commentedNov 3, 2023

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "5.4 and next".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot