Description:
Some webhostings are blocking function "putenv". So, it will show error 500 Error (UndefinedFunction) with text:
Attempted to call function "putenv" from namespace "Symfony\Component\HttpKernel

This PR is checking callability of putenv first, so preventing error 500.

How to test?
-> php.ini - disabled_functions=putenv
-> enable debug

Then you will see error 500
-> After this PR/commit, it's without problem.

For example it's very common problem for PrestaShop users. (PrestaShop is using Symfony)

carsonbot added Status: Needs Review Bug labels

Nov 2, 2023

carsonbot added this to the5.4 milestone

Nov 2, 2023

Copy link

carsonbot commentedNov 2, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

stof requested changes

Nov 2, 2023

View reviewed changes

src/Symfony/Component/HttpKernel/Kernel.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Nov 2, 2023

Copy link

ContributorAuthor

ShaiMagal commentedNov 2, 2023

@stof Updated :)

stof reviewed

Nov 2, 2023

View reviewed changes

src/Symfony/Component/HttpKernel/Kernel.php OutdatedShow resolvedHide resolved

nicolas-grekas added the HttpKernel label

Nov 2, 2023

carsonbot changed the title~~Preventing error 500 when function putenv is disabled~~[HttpKernel] Preventing error 500 when function putenv is disabled

Nov 2, 2023

nicolas-grekas approved these changes

Nov 2, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Nov 2, 2023

OskarStark approved these changes

Nov 2, 2023

View reviewed changes

Copy link

ContributorAuthor

ShaiMagal commentedNov 2, 2023•
edited
Loading

Guys, will this be merged with branch 6.x as well in future or I should make another PR specially for 6.x? (this PR I targeted to 5.4 but I don't know if this will be at 6.x in future... so I am asking, how to do this correctly.

Thank you.

Copy link

Member

stof commentedNov 2, 2023

@ShaiMagal this will be merged up by the core team once this PR is merged (the merge up happens usually once a week for dev version, and it will happen for sure before tagging a release)

Copy link

Member

fabpot commentedNov 2, 2023

Should we do the same insrc/Symfony/Component/BrowserKit/AbstractBrowser.php andsrc/Symfony/Component/Runtime/SymfonyRuntime.php?

Copy link

Member

nicolas-grekas commentedNov 2, 2023

I had a look and I don't think we need to: AbstractBrowser + the spot in Runtime are for command line usages, and to me those are not affected by (cheap) hosters.