Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add--all option tomessenger:consume#52411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me
--all option tomessenger:consumeUh oh!
There was an error while loading.Please reload this page.
OskarStark commentedNov 3, 2023
This must target 7.1 due to feature freeze period |
fabpot commentedDec 4, 2023
Thank you @javaDeveloperKid. |
…ith `--all` option (alexandre-daubois)This PR was merged into the 7.1 branch.Discussion----------[Messenger] Fix timing-out test on `messenger:consume` with `--all` option| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITCI times out since#52411, this aims to fix the test that causes this.Commits-------36307a0 [Messenger] Fix test on `messenger:consume` with `--all` option
Wirone commentedApr 9, 2024
Can you consider this as a bug fix and backport it to 6.4 😂 (jk)? This exactly something we need in our app, where we migrate maaaany workers using multiple transports (because our AMQP instance uses multiple exchanges). It would be much better to use |
alexislefebvre commentedApr 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
What if you use 7.1 in your app? composer require symfony/messenger:^7.1 Update: I just realized that there is a In the meantime, using a commit or the Composer flag |
Wirone commentedApr 9, 2024
@alexislefebvre Thanks for the feedback, but actually I knew it before |
ghost commentedApr 9, 2024 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
@Wirone Another approach would be to copy past this class from 7.1 branch to your respository and register this in your composer,json. Composer will pick up the first class found in this namespace which will be yours. P.S. Remember to check that changes between your 6.4.x locked in your composer.lock and 7.1 branch are only the ones from this PR. If not then decide if it's safe to use it. |
Wirone commentedApr 19, 2024
FYI: I was able to introduce |
Uh oh!
There was an error while loading.Please reload this page.
When implementing this feature the problem with sync transports came out so the
ifstatement for this was needed. I can see someone reported this 2 months ago in#51556. I think this be can fixed properly in a dedicated PR because it requires to dig into MessengerPass I guess.