NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[AssetMapper] Fixing bug where JSCompiler used non-absolute importmap entry path#52368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromweaverryan:asset-mapper-fix-importmap-path-conversion

Oct 31, 2023

Merged

[AssetMapper] Fixing bug where JSCompiler used non-absolute importmap entry path#52368

nicolas-grekas merged 1 commit intosymfony:6.4fromweaverryan:asset-mapper-fix-importmap-path-conversion

Oct 31, 2023

Conversation

Copy link

Member

weaverryan commentedOct 30, 2023

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	None
License	MIT

Introduced over the weekend in#52349.

Thepath key insideimportmap.php can be a full filesystem path or it can start with./ to indicate a relative path to the root directory. That has been the case for weeks. In#52349, when start using thepath of an importmap entry to find theMappedAsset. When doing that, I didn't consider the case wherepath is a relative path.

This PR fixes that and moves the code handling this intoImportMapConfigReader so that we're not repeating it in several places.

Cheers!