Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] Fix deprecated passing null to trim()#52332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromunknown repositoryOct 28, 2023
Merged

[Yaml] Fix deprecated passing null to trim()#52332

fabpot merged 1 commit intosymfony:5.4fromunknown repositoryOct 28, 2023

Conversation

@ghost
Copy link

@ghostghost commentedOct 27, 2023•
edited by GromNaN
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesCloses#52326
LicenseMIT

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR must target the oldest maintained branch where the deprecation exists:5.4.

You should add a test case inInlineTest::getTestsForParse().

@carsonbotcarsonbot changed the title[Yaml] Fix deprecated passing null to trim()Fix deprecated passing null to trim()Oct 28, 2023
@carsonbotcarsonbot changed the titleFix deprecated passing null to trim()[Yaml] Fix deprecated passing null to trim()Oct 28, 2023
@xabbuhxabbuh modified the milestones:6.3,5.4Oct 28, 2023
@fabpot
Copy link
Member

Thank you @javaDeveloperKid.

@fabpotfabpot merged commitb2e372d intosymfony:5.4Oct 28, 2023
@fabpotfabpot mentioned this pull requestOct 29, 2023
xabbuh added a commit that referenced this pull requestOct 29, 2023
This PR was merged into the 6.4 branch.Discussion----------[Yaml] Remove test on `Inline::parse(null)`| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#52334| License       | MITThis test was added by#52332It becomes wrong with#52334It was not reverted byeaff34aCommits-------9b10106 Fix wrong yaml parse null test
This was referencedOct 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasr

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@fabpot@GromNaN@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp