Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[AssetMapper] Fix file deleting errors & remove nullable MappedAsset on JS import#52331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@weaverryan
Copy link
Member

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesNone
LicenseMIT

Hi!

This PR accomplishes 2 things:

A) Ifapp.js importedfoo.js, and you deletedfoo.js, you got a big, unobvious error from Symfony. This was because theMappedAsset behindapp.js remained cached, including theJavaScriptImport forfoo.js. So then, the system was surprised whenapp.js had thisJavaScriptImport... but the underlying file didn't exist. The fix was to add aFileExistenceResource forfoo.js. We don't need to update theapp.js cache iffoo.js changes, but we DO need to update it iffoo.js no longer exists (so that we can create a newMappedAsset without the import).

B) Upon looking at this, previously,JavaScriptImport.asset was nullable. That doesn't make sense, now that all vendor files are downloaded locally and exist in the AssetMapper. TheMappedAsset.javascriptImports are used to implicitly add importmap entries for relative assets (which already required aMappedAsset) and to preload other dependencies. Previously, we added aJavaScriptImport with a null asset for things like absolute imports (`import 'https://example.com/foo.js') or bare imports that we couldn't find. But we can't preload things like this anyway - or we shouldn't bother to in the case of an absolute assets.

For (B), trying to tighten things up and do LESS, if we don't need it.

Cheers!

@fabpotfabpotforce-pushed theasset-mapper-fix-file-deletes branch from300f157 tof1708aaCompareOctober 28, 2023 23:40
@fabpot
Copy link
Member

Thank you@weaverryan.

@fabpotfabpot merged commit6fad9a4 intosymfony:6.4Oct 28, 2023
@weaverryanweaverryan deleted the asset-mapper-fix-file-deletes branchOctober 29, 2023 01:54
xabbuh added a commit that referenced this pull requestOct 29, 2023
This PR was merged into the 6.4 branch.Discussion----------[AssetMapper] Fixing merge| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | None| License       | MITFixing the merge of#52323,#52331 and#52349Also tested on a real project locally to verify the moving pieces :).Thanks!Commits-------99d5cbb [AssetMapper] Fixing merge from multiple PR's
This was referencedOct 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@weaverryan@fabpot@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp