NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[AssetMapper] Fixing memory bug where we stored way more file content than needed#52330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromweaverryan:asset-mapper-memory-improvement

Oct 27, 2023

Merged

[AssetMapper] Fixing memory bug where we stored way more file content than needed#52330

nicolas-grekas merged 1 commit intosymfony:6.4fromweaverryan:asset-mapper-memory-improvement

Oct 27, 2023

Conversation

Copy link

Member

weaverryan commentedOct 27, 2023

Q	A
Branch?	6.4
Bug fix?	yes (on Symfonycasts, without this,`asset-map:compile` takes >500mb of memory)
New feature?	no
Deprecations?	none
Issues	None
License	MIT

Hi!

This drastically improves the memory footprint when ALL assets are built, which happens inasset-map:compile,debug:asset-map, etc. Blackfire is a huge fan!https://blackfire.io/profiles/compare/4eb36732-8805-4c49-b636-d4bf8f9e2b27/graph

The MAIN optimization by far is to setMappedAsset.content to null if the final, compiled content matches the source file's content. This is the case for the vast-majority of mapped assets, and so the result is MUCH less content stored in memory for no reason.

Thanks to@smnandre and his earlier PR, which allows for thenull content on mapped assets.

Cheers!