Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[AssetMapper] Allowing circular references in JavaScriptImportPathCompiler#52323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:6.4fromweaverryan:asset-mapper-allow-circular-workaroundOct 28, 2023
Merged
[AssetMapper] Allowing circular references in JavaScriptImportPathCompiler#52323
fabpot merged 1 commit intosymfony:6.4fromweaverryan:asset-mapper-allow-circular-workaroundOct 28, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ec9e073 to2f98cb3Comparefabpot approved these changesOct 28, 2023
Member
fabpot commentedOct 28, 2023
Thank you@weaverryan. |
2f98cb3 tob0953a4Comparexabbuh added a commit that referenced this pull requestOct 29, 2023
This PR was merged into the 6.4 branch.Discussion----------[AssetMapper] Fixing merge| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | None| License | MITFixing the merge of#52323,#52331 and#52349Also tested on a real project locally to verify the moving pieces :).Thanks!Commits-------99d5cbb [AssetMapper] Fixing merge from multiple PR's
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
In AssetMapper, we throw a
CircularAssetsExceptionif you ask for theapp.jsasset, but it's still being created. This circular situation only happens via asset compilers: if, while compilingapp.js, we ask forother.js... and then while compiling that, we ask forapp.js.However, JS modulesdo allow for circular references - e.g.
app.jsimportsother.jswhich importsapp.js. Before this PR, this situation would trigger theCircularAssetsException. After, it is handled correctly.JavaScriptImportPathCompilercalls$assetMapper->getAsset()only to populate theMappedAsset.javaScriptImportsproperty. So, allowing for the half-createdMappedAssetis safe here: we do not use any of the not-yet-populated properties.Cheers!