Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DebugBundle] ignore a not-existing virtual request stack#52290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedOct 25, 2023
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix#52280 |
| License | MIT |
| service('debug.file_link_formatter')->ignoreOnInvalid(), | ||
| param('kernel.charset'), | ||
| service('.virtual_request_stack'), | ||
| service('.virtual_request_stack')->ignoreOnInvalid(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't we instead pass the request stack when the virtual one doesn't exist? that'd match the previous behavior
the solution might be to alias the virtual stack to the real one in FWB when not in debug, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I did that in a compiler pass now. Adding an alias is probably not a solution as long as we do not want to list older versions of the FrameworkBundle as a conflict.
nicolas-grekas commentedOct 26, 2023
Thank you@xabbuh. |