Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fix deprecation layer for "enable_annotations" in validation and serializer configuration#52287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromlyrixx:enable_annotations
Oct 31, 2023

Conversation

lyrixx
Copy link
Member

@lyrixxlyrixx commentedOct 25, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

With Symfony 6.4 (without this patch) and the following configuration

framework:serializer:enable_annotations:true
>…gregoire/dev/labs/symfony/symfony-6.4(main *) bin/console In BaseNode.php line 435:                                                                                                                                                                                              Invalid configuration for path "framework.serializer": The "enable_annotations" and "enable_attributes" options at path "framework.serializer" must not be both set. Only the "enable_at    tributes" option must be used.                                                                                                                                                                                                                                                                                                                                                        In Configuration.php line 1163:                                                                                                                                                                     The "enable_annotations" and "enable_attributes" options at path "framework.serializer" must not be both set. Only the "enable_attributes" option must be used.

With this PR

tests:

framework:serializer:enable_annotations:true

Compilation is OK
Note : this is the previous configuration for some app

framework:serializer:enable_annotations:trueenable_attributes:true# same results with false, or null

Compilation is KO
Error :

Invalid configuration for path "framework.serializer": The "enable_annotations" and "enable_attributes" options at path "framework.serializer" must not be both set. Only the "enable_attributes" option must be used.

framework:serializer:enable_attributes:true# same results with false, or null

Compilation is OK

framework:serializer:~

Compilation is OK

alexandre-daubois reacted with thumbs up emoji
@carsonbotcarsonbot added this to the6.4 milestoneOct 25, 2023
@nicolas-grekasnicolas-grekas changed the title[FrameworkBundle] Fix BC break about enable_annotations in validation and serializer configuration[FrameworkBundle] Fix deprecation layer for "enable_annotations" in validation and serializer configurationOct 25, 2023
@lyrixx
Copy link
MemberAuthor

@stof I pushed a new version. I now usebeforeNormalization and I was able to revert the change aboutdefaultNull()

@nicolas-grekas
Copy link
Member

Thank you@lyrixx.

lyrixx reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit17dee5b intosymfony:6.4Oct 31, 2023
@lyrixxlyrixx deleted the enable_annotations branchOctober 31, 2023 08:00
This was referencedNov 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@derrabusderrabusderrabus approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@lyrixx@nicolas-grekas@stof@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp