This reorders the query to target thequeue_name first and not include anyfailed messages in the first part of theWHERE clause to help performance.

carsonbot added Status: Needs Review Bug labels

Oct 24, 2023

carsonbot added this to the5.4 milestone

Oct 24, 2023

Copy link

ContributorAuthor

bn-jdcook commentedOct 24, 2023

I am not sure why AppVeyor is failing but it appears to be on all PRs to 5.4.

OskarStark changed the title~~fix #52273 [doctrine-messenger] DB table locks on messenger_messages …~~[Medsenger][Doctrine] DB table locks on messenger_messages …

Oct 25, 2023

OskarStark changed the title~~[Medsenger][Doctrine] DB table locks on messenger_messages …~~[Medsenger][Doctrine] DB table locks on messenger_messages wirh many failures

Oct 25, 2023

OskarStark changed the title~~[Medsenger][Doctrine] DB table locks on messenger_messages wirh many failures~~[Messenger][Doctrine] DB table locks on messenger_messages wirh many failures

Oct 25, 2023

fixsymfony#52273[doctrine-messenger] DB table locks on messenger_me…

3245280

…ssages with many failures

bn-jdcook force-pushed thefix_52273 branch frombdaabc0 to3245280Compare

October 25, 2023 13:42

nicolas-grekas changed the title~~[Messenger][Doctrine] DB table locks on messenger_messages wirh many failures~~[Messenger][Doctrine] DB table locks on messenger_messages with many failures

Oct 25, 2023

nicolas-grekas approved these changes

Oct 25, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Oct 25, 2023

carsonbot changed the title~~[Messenger][Doctrine] DB table locks on messenger_messages with many failures~~DB table locks on messenger_messages with many failures

Oct 25, 2023

fabpot approved these changes

Oct 25, 2023

View reviewed changes

Copy link

Member

fabpot commentedOct 25, 2023

Thank you@bn-jdcook.

fabpot merged commitb34c4c7 intosymfony:5.4

Oct 25, 2023

bn-jdcook deleted the fix_52273 branch

October 25, 2023 19:16

Copy link

antonkomarev commentedOct 25, 2023•
edited
Loading

@bn-jdcook how does this affect performance? Doesn't the database query planner care about the order of WHERE clauses?

What database are you using? Have you tried to make EXPLAIN to see if the query plan is different?

// I'm not against these changes. Order is more logical now. But I haven't faced such issues in Postgres.

Copy link

ghost commentedOct 25, 2023

What database are you using?

I agree a reporter should mention a database he's using when reporting an issue related to the database.

Btw. I really wonder whether a database can create a query plan that knows which AND condition to use first (unless both columns do not differ somehow from database point of view). E.g. how can it know that filtering first byqueue_name will be more efficient.