NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer][Notifier] Update Sendinblue / Brevo API host#52268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromvicla31:fix_#52264_update_brevo_api_host

Oct 24, 2023

Merged

[Mailer][Notifier] Update Sendinblue / Brevo API host#52268

nicolas-grekas merged 1 commit intosymfony:5.4fromvicla31:fix_#52264_update_brevo_api_host

Oct 24, 2023

Conversation

Copy link

vicla31 commentedOct 24, 2023

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#52264
License	MIT

Sendinblue rebrands to Brevo, and it simultaneously upgrade smtp and API servers.
There are 2 distincts API currently : api.sendinblue.com (deprecated but still running) and api.brevo.com (the one to use)
Unlike SMTP host, API host is not changed on LTS 5.4 and are still set to api.sendinblue.com.

[Mailer] [Notifier]symfony#52264Update Sendinblue / Brevo API host

554e9cc

vicla31 requested a review fromOskarStark as acode owner

October 24, 2023 12:10

carsonbot added Status: Needs Review Bug Mailer Notifier labels

Oct 24, 2023

carsonbot added this to the5.4 milestone

Oct 24, 2023

carsonbot changed the title~~[Mailer] [Notifier] #52264 Update Sendinblue / Brevo API host~~[Mailer][Notifier] #52264 Update Sendinblue / Brevo API host

Oct 24, 2023

Copy link

carsonbot commentedOct 24, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot