Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Skip merging params & files if there are no files in the first place#52255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4frompriyadi:workaround-52248
Oct 24, 2023
Merged

Conversation

@priyadi
Copy link
Contributor

@priyadipriyadi commentedOct 24, 2023•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#52248
LicenseMIT

Skip merging params & files if there are no files in the first place. Works around problems with numeric field names.

dmaicher reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedOct 24, 2023•
edited
Loading

In addition, what about usingarray_is_list() to decide what to do with keys?

@priyadi
Copy link
ContributorAuthor

In addition, what about usingarray_is_list() to decide what to do with keys?

good idea. done.

@nicolas-grekasnicolas-grekas modified the milestones:6.3,5.4Oct 24, 2023
@nicolas-grekasnicolas-grekas changed the titleSkip merging params & files if there are no files in the first place. Works around problems with numeric field names.Skip merging params & files if there are no files in the first placeOct 24, 2023
@carsonbotcarsonbot changed the titleSkip merging params & files if there are no files in the first place[Form] Skip merging params & files if there are no files in the first placeOct 24, 2023
@nicolas-grekasnicolas-grekas changed the base branch from6.3 to5.4October 24, 2023 09:12
@OskarStark
Copy link
Contributor

cc@dmaicher

dmaicher reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@priyadi.

dmaicher reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitb769b77 intosymfony:5.4Oct 24, 2023
@dmaicher
Copy link
Contributor

Thanks for the fast fix@priyadi@nicolas-grekas 🚀 👍

mfruehauf reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixx

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@priyadi@nicolas-grekas@OskarStark@dmaicher@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp