Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Ability to add roles inform_login_ldap by ldap group#52181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromSpomky:features/ldap_roles
Feb 10, 2025

Conversation

Spomky
Copy link
Contributor

@SpomkySpomky commentedOct 19, 2023•
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#51225
LicenseMIT

This PR adds a way for setting roles inform_login_ldap based on LDAP configuration.
Please note that it is based on SF6.4, but may be changed to 7.1 if already in feature freeze period. => Rebased for targeting SF 7.1

  • Feature
  • Tests
  • Documentation

nxtpge, mvhirsch, and MDeveloping reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

Please note that it is based on SF6.4, but may be changed to 7.1 if already in feature freeze period.

Yes it will be for 7.1, but you can already rebase on and target 7.0 if you like

Spomky reacted with thumbs up emoji

@SpomkySpomky changed the base branch from6.4 to7.0October 20, 2023 16:23
@SpomkySpomkyforce-pushed thefeatures/ldap_roles branch 3 times, most recently from2a66af5 to840f533CompareOctober 20, 2023 19:51
@SpomkySpomky changed the base branch from7.0 to7.1February 1, 2024 19:58
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What would be the typical implementation for a role fetcher? Can we provide one that e.g. reads some conventional entries from theEntry?

Spomky reacted with thumbs up emoji
@xabbuhxabbuh modified the milestones:7.1,7.2May 15, 2024
@MDeveloping
Copy link

MDeveloping commentedAug 23, 2024•
edited
Loading

Did I understand this correct, that there will be an easy way, to read the memberOf of a LDAP User if logging in and than set a role?
Did I also understand it correct, that this will be available at Symphony 7.2 ad that a documentation is missing for now on Symfony Docs?

@OskarStarkOskarStark changed the title[Security] Ability to add roles in form_login_ldap by ldap group[Security] Ability to add roles inform_login_ldap by ldap groupAug 25, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@SpomkySpomkyforce-pushed thefeatures/ldap_roles branch 3 times, most recently fromcdd873f to80eb8a3CompareJanuary 18, 2025 07:40
Copy link
Member

@welcoMatticwelcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

2 minor comments, otherwise it's 👍 for me

@SpomkySpomkyforce-pushed thefeatures/ldap_roles branch 2 times, most recently from15aab3b to5e8b1c7CompareFebruary 7, 2025 19:51
This update allows LDAP to fetch roles for a given user entry by using the new RoleFetcherInterface. The LdapUserProvider class has been adjusted to use this new functionality.
@fabpot
Copy link
Member

Thank you@Spomky.

@fabpotfabpot merged commit4ecc160 intosymfony:7.3Feb 10, 2025
10 of 11 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuh

@lyrixxlyrixxAwaiting requested review from lyrixx

@dunglasdunglasAwaiting requested review from dunglas

@ycerutoycerutoAwaiting requested review from yceruto

@kbondkbondAwaiting requested review from kbond

@jderussejderusseAwaiting requested review from jderusse

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Security] Ability to add roles inform_login_ldap by ldap group
8 participants
@Spomky@OskarStark@MDeveloping@fabpot@nicolas-grekas@welcoMattic@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp