Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Tests] MoveexpectException closer to the place of the expectation to avoid false positives#52157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromOskarStark:feature/expect
Oct 31, 2023

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedOct 19, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Tickets--
LicenseMIT

If you guys like this PR, I will fix the other places as well

Should be merged after merge & upmerge of:

@OskarStarkOskarStark requested a review fromstofOctober 19, 2023 05:17
@carsonbotcarsonbot added this to the6.4 milestoneOct 19, 2023
@OskarStarkOskarStark mentioned this pull requestOct 30, 2023
@nicolas-grekas
Copy link
Member

  1. Symfony\Component\Console\Tests\Helper\TableTest::testThrowsWhenTheCellInAnArray
    Failed asserting that exception of type "Symfony\Component\Console\Exception\InvalidArgumentException" is thrown.

Related isn't it?

OskarStark reacted with thumbs up emoji

@OskarStark
Copy link
ContributorAuthor

Test failures unrelated

nicolas-grekas added a commit that referenced this pull requestOct 31, 2023
This PR was squashed before being merged into the 5.4 branch.Discussion----------[Tests] Streamline| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | --| License       | MITExtracted from#52157Commits-------918f677 [Tests] Streamline
@OskarStark
Copy link
ContributorAuthor

Test failures unrelated

@nicolas-grekas
Copy link
Member

Thank you@OskarStark.

OskarStark reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit382564d intosymfony:6.4Oct 31, 2023
@keradus
Copy link
Member

keradus commentedOct 31, 2023•
edited
Loading

❤️ for change!

If you guys like this PR, I will fix the other places as well

@OskarStark , if you are up for it, maybe a new Fixer rule?

@OskarStarkOskarStark mentioned this pull requestNov 1, 2023
nicolas-grekas added a commit that referenced this pull requestDec 26, 2023
This PR was squashed before being merged into the 7.1 branch.Discussion----------[Tests] Streamline| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | --| License       | MITFollows*#52157*#52365Commits-------33d71aa [Tests] Streamline
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusAwaiting requested review from derrabus

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@OskarStark@nicolas-grekas@keradus@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp