Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpKernel] Add option to map empty data withMapQueryString
andMapRequestPayload
#52134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Jeroeny wants to merge1 commit intosymfony:7.4Choose a base branch fromJeroeny:mapempty
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…for always attempting denormalization with empty query and request payload
Victor-Truhanovich approved these changesFeb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is excellent, necessary and useful pull request
@nicolas-grekas May I know when this PR will be accepted and merged? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It would be nice if the
RequestPayloadValueResolver
could optionally call theserializer->denormalize
method regardless if$request->query
,$request->request
or$request->getContent()
is empty.Because if a DTO/request has optional arguments combined with some system-provided arguments, the data could be empty while the controller may still require this DTO class.
Also in cases where there are only required arguments, it is beneficial for the user to see which request arguments are needed. The
PartialDenormalizationException
may show this.For example:
Where the
$userId
is provided by a custom normalizer that retrieves it from the Symfony Security User object. If$name
isn't passed in the request, the class won't be constructed.