Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fix horizontal table top border is incorrectly rendered#52132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedOct 18, 2023
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#52101
LicenseMIT

cc@alainrinder

@OskarStark
Copy link
ContributorAuthor

Fabbot is false positive

@GromNaN
Copy link
Member

The issue might be with unicode characters. Could you add an emoji in the values?

@OskarStark
Copy link
ContributorAuthor

The issue might be with unicode characters. Could you add an emoji in the values?

Lets try the fix from the bug report

@OskarStarkOskarStark changed the title[Console] Add tests[Console] Fix table renderingOct 18, 2023
@OskarStarkOskarStark self-assigned thisOct 18, 2023
@OskarStark
Copy link
ContributorAuthor

What's the difference here?
CleanShot 2023-10-18 at 11 47 39@2x

@OskarStarkOskarStark changed the title[Console] Fix table rendering[Console] Fix horizontal table top border is incorrectly renderedOct 19, 2023
@@ -411,7 +411,7 @@ public function render()

if ($isHeader && !$isHeaderSeparatorRendered) {
$this->renderRowSeparator(
$isHeader ?self::SEPARATOR_TOP : self::SEPARATOR_TOP_BOTTOM,
self::SEPARATOR_TOP,
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I removed this, because$isHeader is always true

maxbeckers reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Thank you@OskarStark.

OskarStark reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit7a59ef0 intosymfony:6.3Oct 31, 2023
@OskarStarkOskarStark deleted the fix/console-table-border branchOctober 31, 2023 08:13
This was referencedNov 10, 2023
renovatebot added a commit to Lendable/composer-license-checker that referenced this pull requestNov 13, 2023
[![MendRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [symfony/console](https://symfony.com)([source](https://togithub.com/symfony/console)) | `6.3.4` -> `6.3.8` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fconsole/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fconsole/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fconsole/6.3.4/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fconsole/6.3.4/6.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>symfony/console (symfony/console)</summary>### [`v6.3.8`](https://togithub.com/symfony/console/releases/tag/v6.3.8)[CompareSource](https://togithub.com/symfony/console/compare/v6.3.4...v6.3.8)**Changelog**(symfony/console@v6.3.7...v6.3.8)- bug[symfony/symfony#52132](https://togithub.com/symfony/symfony/issues/52132)\[Console] Fix horizontal table top border is incorrectly rendered([@&#8203;OskarStark](https://togithub.com/OskarStark))</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/Lendable/composer-license-checker).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gordinskiygordinskiygordinskiy left review comments

@maxbeckersmaxbeckersmaxbeckers approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

@fabpotfabpotAwaiting requested review from fabpot

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

@OskarStarkOskarStark

Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

6 participants
@OskarStark@GromNaN@nicolas-grekas@maxbeckers@gordinskiy@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp