NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Add ext-pcntl to composer.json#52129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

beesofts wants to merge1 commit intosymfony:6.4frombeesofts:patch-1

Closed

[Messenger] Add ext-pcntl to composer.json#52129

beesofts wants to merge1 commit intosymfony:6.4frombeesofts:patch-1

Conversation

Copy link

beesofts commentedOct 18, 2023

Since ConsumeMessagesCommand.php uses SIGTERM and SIGINT, ext-pcntl must be available on system

Add ext-pcntl to composer.json

75cb755

Since ConsumeMessagesCommand.php uses SIGTERM and SIGINT, ext-pcntl must be available on system

carsonbot added the Status: Needs Review label

Oct 18, 2023

carsonbot added this to the6.4 milestone

Oct 18, 2023

Copy link

carsonbot commentedOct 18, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot