Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Remove temporary cache item file onrename() failure#52105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I pushed a slightly different implementation, can you please confirm it works for you?
cedric-anne commentedOct 17, 2023
I confirm it fixes the issue. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedOct 17, 2023
Thank you@cedric-anne. |
The filesystem cache adapter creates a temporary file to store cache item data, then moves it to its target path using
rename()function. If rename fails, for instance target path is not writable, the temporary file will remains.To prevent filesystem saturation, the temporary files should be deleted if this operation is not done by the
rename()function itself.