Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] Remove temporary cache item file onrename() failure#52105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromcedric-anne:fix/delete-cache-tmp-file
Oct 17, 2023
Merged

[Cache] Remove temporary cache item file onrename() failure#52105

nicolas-grekas merged 1 commit intosymfony:5.4fromcedric-anne:fix/delete-cache-tmp-file
Oct 17, 2023

Conversation

@cedric-anne
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#52092
LicenseMIT

The filesystem cache adapter creates a temporary file to store cache item data, then moves it to its target path usingrename() function. If rename fails, for instance target path is not writable, the temporary file will remains.

To prevent filesystem saturation, the temporary files should be deleted if this operation is not done by therename() function itself.

artyuum reacted with thumbs up emoji
@cedric-annecedric-anne marked this pull request as ready for reviewOctober 17, 2023 12:01
@carsonbotcarsonbot added this to the5.4 milestoneOct 17, 2023
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I pushed a slightly different implementation, can you please confirm it works for you?

@cedric-anne
Copy link
ContributorAuthor

I pushed a slightly different implementation, can you please confirm it works for you?

I confirm it fixes the issue.

@symfonysymfony deleted a comment fromcarsonbotOct 17, 2023
@nicolas-grekas
Copy link
Member

Thank you@cedric-anne.

@nicolas-grekasnicolas-grekas merged commit8c02677 intosymfony:5.4Oct 17, 2023
@cedric-annecedric-anne deleted the fix/delete-cache-tmp-file branchOctober 17, 2023 14:41
@fabpotfabpot mentioned this pull requestOct 21, 2023
@fabpotfabpot mentioned this pull requestOct 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

+1 more reviewer

@staabmstaabmstaabm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@cedric-anne@nicolas-grekas@staabm@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp