Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier][Sendinblue] Handle error responses without a message key#52095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| if (201 !==$statusCode) { | ||
| thrownewHttpTransportException('Unable to send an email:'.$result['message'].sprintf(' (code %d).',$statusCode),$response); | ||
| thrownewHttpTransportException('Unable to send an email:'.($error['message'] ??$response->getContent(false)).sprintf(' (code %d).',$statusCode),$response); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| thrownewHttpTransportException('Unable to send an email:'.($error['message'] ??$response->getContent(false)).sprintf(' (code %d).',$statusCode),$response); | |
| thrownewHttpTransportException('Unable to send an email:'.($result['message'] ??$response->getContent(false)).sprintf(' (code %d).',$statusCode),$response); |
Contributor
OskarStark commentedOct 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
As Brevo is the 1:1 replacement for Sendinblue after their rebranding, can you please also update Mailer/Brevo and Notifier/Brevo bridges? Thanks |
MemberAuthor
stof commentedOct 17, 2023
@OskarStark done in#52096 as the Brevo transports only exist in the 6.4 branch, not in 5.4 |
a9fb5e5 to8ae8993CompareOskarStark approved these changesOct 17, 2023
Member
nicolas-grekas commentedOct 17, 2023
Thank you@stof. |
nicolas-grekas added a commit that referenced this pull requestOct 17, 2023
…e key (stof)This PR was merged into the 6.4 branch.Discussion----------[Notifier] [Brevo] Handle error responses without a message key| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MITDuring their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response.This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails.This is the same change than#52095 but for the new Brevo bridgeCommits-------517ceae Handle Brevo error responses without a message key
symfony-splitter pushed a commit to symfony/brevo-notifier that referenced this pull requestOct 17, 2023
…e key (stof)This PR was merged into the 6.4 branch.Discussion----------[Notifier] [Brevo] Handle error responses without a message key| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MITDuring their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response.This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails.This is the same change thansymfony/symfony#52095 but for the new Brevo bridgeCommits-------517ceaea03 Handle Brevo error responses without a message key
symfony-splitter pushed a commit to symfony/brevo-mailer that referenced this pull requestOct 17, 2023
…e key (stof)This PR was merged into the 6.4 branch.Discussion----------[Notifier] [Brevo] Handle error responses without a message key| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MITDuring their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response.This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails.This is the same change thansymfony/symfony#52095 but for the new Brevo bridgeCommits-------517ceaea03 Handle Brevo error responses without a message key
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During their outage yesterday where the endpoint returned errors with status code 500, there was no
messagekey in the json response.This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails.