Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Scheduler] AddFailureEvent#52087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dd70b10 to56f2c93Compare| $this->dispatcher->dispatch(newPostRunEvent($generator->getSchedule(),$context,$message)); | ||
| $this->dispatcher->dispatch(newPostRunEvent($generator->getSchedule(),$context,$message)); | ||
| }catch (\Throwable$error) { | ||
| $this->dispatcher->dispatch(newFailureEvent($generator->getSchedule(),$context,$message,$error)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to rethrow the exception, right?
And maybe the FailureEvent can have a way to ignore the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes indeed. Maybe I could add ashouldIgnore like the one we already have for theWorkerMessageReceivedEvent
329592e toe39d744Comparee39d744 to891a404Comparefabpot commentedOct 17, 2023
Thank you@alli83. |
Following PR#51805, It would be interesting to add a
failureEventallowing you, for instance, to remove the recurring message, depending on the error caught.