I would like to use another amqp queue for dead letter after retries failed. I expected the message to be sent to the failure transport queue. It wasn't.

My initial configuration:

framework:messenger:transports:async:dsn:'%env(MESSENGER_TRANSPORT_DSN)%'retry_strategy:max_retries:3delay:30000multiplier:2max_delay:300000failure_transport:failureoptions:exchange:type:directname:my_exchange_namedefault_publish_routing_key:commonqueues:my_queue_name:binding_keys:[common]failure:dsn:'%env(MESSENGER_TRANSPORT_DSN)%'options:exchange:type:directname:my_exchange_namedefault_publish_routing_key:failedqueues:my_failure_queue:binding_keys:[failed]

I found the issue#37985 that already mentioned the problem. A workaround using queue name as routing key for failure queue is already proposed. It is not obvious...

binding_keys: [failed, my_queue_name]

After some debug, I found the routing key is not correctly set in case of failure transport. Exchange configuration is good but routing key uses previous routing key set by retry mechanism. And retry mechanism use queue name.

Routing key comes fromRedeliveryStamp and usesasync queue name as routing key. It is not what I expected. But I understand it is required by the retry mechanism to push delayed message to the original queue.

Finally I propose a little modification to take into account theSentToFailureTransportStamp and force to publish with the failure routing key by default.

I think this fix could be pushed to 5.4 but I didn't test it.

carsonbot added Status: Needs Review Bug Messenger labels

Oct 16, 2023

carsonbot added this to the6.3 milestone

Oct 16, 2023

Copy link

carsonbot commentedOct 16, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

carsonbot changed the title~~[Messenger][Amqp] Fix wrong routing key when use failure queue~~[Messenger] [Amqp] Fix wrong routing key when use failure queue

Oct 16, 2023

OskarStark changed the title~~[Messenger] [Amqp] Fix wrong routing key when use failure queue~~[Messenger][Amqp] Fix wrong routing key when use failure queue

Oct 17, 2023