NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] increase lower bound of symfony/service-contracts#52042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

xabbuh wants to merge1 commit intosymfony:6.4fromxabbuh:pr-51832

Closed

[DependencyInjection] increase lower bound of symfony/service-contracts#52042

xabbuh wants to merge1 commit intosymfony:6.4fromxabbuh:pr-51832

Conversation

Copy link

Member

xabbuh commentedOct 13, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets
License	MIT

increase lower bound of symfony/service-contracts

8917098

carsonbot added Status: Needs Review DependencyInjection labels

Oct 13, 2023

carsonbot added this to the6.4 milestone

Oct 13, 2023

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, I forgot about this one.
Any other idea to account for#51832 (review)?
Maybe we should skip the test case when contracts < 3.2 is loaded instead? (and throw in the code - or do nothing waiting for someone to hit this for-now hypothetical situation?)