Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Fix DBAL 4 compatibility#52035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromderrabus:bugfix/dbal-4
Oct 13, 2023

Conversation

@derrabus
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT

This PR backports DBAL 4 compatibility changes from#51997 that were not in#51947. Sorry for messing this up.

@carsonbot

This comment was marked as outdated.

@derrabusderrabus changed the base branch from6.4 to5.4October 13, 2023 09:15
@derrabusderrabus modified the milestones:6.4,5.4Oct 13, 2023
@nicolas-grekasnicolas-grekas changed the titleBugfix/dbal 4Fix DBAL 4 compatibilityOct 13, 2023
@carsonbotcarsonbot changed the titleFix DBAL 4 compatibility[DoctrineBridge] Fix DBAL 4 compatibilityOct 13, 2023
@derrabusderrabusforce-pushed thebugfix/dbal-4 branch 3 times, most recently frome6e497e tob7b549eCompareOctober 13, 2023 09:45
@derrabus
Copy link
MemberAuthor

I've addressed your remarks,@stof.

@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commit053b814 intosymfony:5.4Oct 13, 2023
@derrabusderrabus deleted the bugfix/dbal-4 branchOctober 13, 2023 10:18
@fabpotfabpot mentioned this pull requestOct 21, 2023
@fabpotfabpot mentioned this pull requestOct 29, 2023
@arderyp
Copy link
Contributor

@fabpot this issue seems to suggest DBAL 4is supported as of late October 2023, but a commit you made in February 2024 onsymfony/orm-pack suggests that DBAL 4 isnot supported:symfony/orm-pack@266bae0

Am I missing something?

@nicolas-grekas
Copy link
Member

See the PR attached to the commit you linked:symfony/orm-pack#43
Symfony is compatible, but not 100% of it, yet.

arderyp reacted with thumbs up emoji

@stof
Copy link
Member

stof commentedMar 5, 2024

symfony/doctrine-bridge is compatible.
However, symfony/messenger-doctrine is not 100% compatible yet

arderyp reacted with thumbs up emoji

@arderyp
Copy link
Contributor

arderyp commentedMar 5, 2024•
edited
Loading

Thanks for the clarifications, I will avoid it for now

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@derrabus@carsonbot@nicolas-grekas@arderyp@stof
[8]ページ先頭
©2009-2025 Movatter.jp