Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][Routing][Translation][Workflow] Move some compiler passes from FrameworkBundle to components#52032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromfancyweb:fwb/move-workflow-cp
Oct 19, 2023

Conversation

fancyweb
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
Tickets-
LicenseMIT

MoveAddExpressionLanguageProvidersPass tosymfony/routing
MoveDataCollectorTranslatorPass andLoggingTranslatorPass tosymfony/translation
MoveWorkflowGuardListenerPass tosymfony/workflow

@@ -157,7 +157,7 @@ public function build(ContainerBuilder $container)
$this->addCompilerPassIfExists($container, TranslatorPass::class, PassConfig::TYPE_BEFORE_OPTIMIZATION, -32);
$this->addCompilerPassIfExists($container, TranslatorPathsPass::class, PassConfig::TYPE_AFTER_REMOVING);
$container->addCompilerPass(new LoggingTranslatorPass());
$container->addCompilerPass(new AddExpressionLanguageProvidersPass(false));
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's no constructor so the argument is unused.

OskarStark reacted with thumbs up emoji
@fancywebfancywebforce-pushed thefwb/move-workflow-cp branch 2 times, most recently from5041b7d toed7a6ffCompareOctober 18, 2023 07:25
@nicolas-grekasnicolas-grekas added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 18, 2023
@nicolas-grekas
Copy link
Member

Thank you@fancyweb.

@nicolas-grekasnicolas-grekas merged commitf5178e0 intosymfony:6.4Oct 19, 2023
@fancywebfancyweb deleted the fwb/move-workflow-cp branchOctober 19, 2023 15:16
@PhilETaylor
Copy link
Contributor

Think this broke something on a stable 6.4.x-dev upgraded to

- Upgrading symfony/framework-bundle (6.4.x-dev 6499aed => 6.4.x-dev afc557e): Extracting archive

I dont havesymfony/workflow installed in my project and now I get this:

 [KO]Script base:composer:manifest returned with error code 255!!  Symfony\Component\ErrorHandler\Error\ClassNotFoundError {#175!!    #message: """!!      Attempted to load class "WorkflowGuardListenerPass" from namespace "Symfony\Component\Workflow\DependencyInjection".\n!!      Did you forget a "use" statement for "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass"?!!      """!!    #code: 0!!    #file: "./vendor/symfony/framework-bundle/FrameworkBundle.php"!!    #line: 171!!    trace: {!!      ./vendor/symfony/framework-bundle/FrameworkBundle.php:171 { …}!!      ./vendor/symfony/http-kernel/Kernel.php:630 { …}!!      ./vendor/symfony/http-kernel/Kernel.php:603 { …}!!      ./vendor/symfony/http-kernel/Kernel.php:505 { …}!!      ./vendor/symfony/http-kernel/Kernel.php:757 { …}!!      ./vendor/symfony/http-kernel/Kernel.php:126 { …}!!      ./vendor/symfony/framework-bundle/Console/Application.php:184 { …}!!      ./vendor/symfony/framework-bundle/Console/Application.php:72 { …}!!      ./vendor/symfony/console/Application.php:175 { …}!!      ./vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:49 { …}!!      ./vendor/autoload_runtime.php:29 { …}!!      ./bin/console:11 {!!        ›!!        › require_once dirname(__DIR__).'/vendor/autoload_runtime.php';!!        ›!!        arguments: {!!          "/Users/phil/Sites/myBackups.guru/vendor/autoload_runtime.php"!!        }!!      }!!    }!!  }!!  2023-10-19T17:32:19+00:00 [critical] Uncaught Error: Class "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" not found!!  2023-10-19T17:32:19+00:00 [info] User Deprecated: Since symfony/framework-bundle 6.4: The "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass" class is deprecated, use "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" instead.!!Script @auto-scripts was called via post-update-cmd

@fancyweb
Copy link
ContributorAuthor

fancyweb commentedOct 19, 2023 via email

I missed that. Translation and Workflow are not hard dependencies of FWB sowe can’t require the new compiler passes unconditionally.
…
On Thu 19 Oct 2023 at 19:35, Phil E. Taylor ***@***.***> wrote: Think this broke something on a stable 6.4.x-dev upgraded to - Upgrading symfony/framework-bundle (6.4.x-dev 6499aed => 6.4.x-dev afc557e): Extracting archive I dont have symfony/workflow installed in my project and now I get this: [KO] Script base:composer:manifest returned with error code 255 !! Symfony\Component\ErrorHandler\Error\ClassNotFoundError {#175 !! #message: """ !! Attempted to load class "WorkflowGuardListenerPass" from namespace "Symfony\Component\Workflow\DependencyInjection".\n !! Did you forget a "use" statement for "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass"? !! """ !! #code: 0 !! #file: "./vendor/symfony/framework-bundle/FrameworkBundle.php" !! #line: 171 !! trace: { !! ./vendor/symfony/framework-bundle/FrameworkBundle.php:171 { …} !! ./vendor/symfony/http-kernel/Kernel.php:630 { …} !! ./vendor/symfony/http-kernel/Kernel.php:603 { …} !! ./vendor/symfony/http-kernel/Kernel.php:505 { …} !! ./vendor/symfony/http-kernel/Kernel.php:757 { …} !! ./vendor/symfony/http-kernel/Kernel.php:126 { …} !! ./vendor/symfony/framework-bundle/Console/Application.php:184 { …} !! ./vendor/symfony/framework-bundle/Console/Application.php:72 { …} !! ./vendor/symfony/console/Application.php:175 { …} !! ./vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:49 { …} !! ./vendor/autoload_runtime.php:29 { …} !! ./bin/console:11 { !! › !! › require_once dirname(__DIR__).'/vendor/autoload_runtime.php'; !! › !! arguments: { !! "/Users/phil/Sites/myBackups.guru/vendor/autoload_runtime.php" !! } !! } !! } !! } !! 2023-10-19T17:32:19+00:00 [critical] Uncaught Error: Class "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" not found !! 2023-10-19T17:32:19+00:00 [info] User Deprecated: Since symfony/framework-bundle 6.4: The "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass" class is deprecated, use "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" instead. !! Script @auto-scripts was called via post-update-cmd — Reply to this email directly, view it on GitHub <#52032 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA35DB3Q7YP3FY7HZUNTX3TYAFQHHAVCNFSM6AAAAAA562T5I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGQZTCOJXGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>
PhilETaylor reacted with thumbs up emoji

@PhilETaylor
Copy link
Contributor

PhilETaylor commentedOct 19, 2023•
edited
Loading

@fancyweb I have logged this here#52187 so that this comment doesnt get lost, I see you posted by email and might be unable to address it right away, so hope an open issue prevents duplicate issues (No pressure from me or rush needed, but the framework in 6.4.x is broken at the moment :)) - Also PayPal 💰

fancyweb reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestOct 20, 2023
… only if it exists (smnandre)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle][Workflow] Add `WorflowGuardListenerPass` only if it exists| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#52187| License       | MITAs spotted by `@PhilETaylor` (in [this comment](#52032 (comment))) the framework is broken in 6.4-dev when the worflow component is not installed.This PR fixes that by registering the compiler pass only if available.Commits-------1ba348a Add WorflowGuardListenerPass only if it exists
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestOct 20, 2023
… only if it exists (smnandre)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle][Workflow] Add `WorflowGuardListenerPass` only if it exists| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Fix #52187| License       | MITAs spotted by `@PhilETaylor` (in [this comment](symfony/symfony#52032 (comment))) the framework is broken in 6.4-dev when the worflow component is not installed.This PR fixes that by registering the compiler pass only if available.Commits-------1ba348a7e13 Add WorflowGuardListenerPass only if it exists
fabpot added a commit that referenced this pull requestOct 20, 2023
…cyweb)This PR was merged into the 7.0 branch.Discussion----------[FrameworkBundle] Remove deprecated compiler passes| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MITRemove deprecated code in#52032Commits-------7984404 [FrameworkBundle] Remove deprecated compiler passes
nicolas-grekas added a commit that referenced this pull requestOct 20, 2023
…er passes (fancyweb)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] Fix requiring moved translation compiler passes| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#52032 (comment)| License       | MITThose 2 also need to be required conditionally since symfony/translation is not a hard dependency of FWB.Commits-------2b95681 [FrameworkBundle] Fix requiring moved translation compiler passes
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestOct 20, 2023
…er passes (fancyweb)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] Fix requiring moved translation compiler passes| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |symfony/symfony#52032 (comment)| License       | MITThose 2 also need to be required conditionally since symfony/translation is not a hard dependency of FWB.Commits-------2b95681764 [FrameworkBundle] Fix requiring moved translation compiler passes
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@welcoMatticwelcoMatticwelcoMattic left review comments

@OskarStarkOskarStarkOskarStark left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

Assignees
No one assigned
Labels
DeprecationFrameworkBundleRouting❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: ReviewedTranslationWorkflow
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

7 participants
@fancyweb@nicolas-grekas@PhilETaylor@stof@welcoMattic@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp