NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Fix merging params & files when "multiple" is enabled#52021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4frompriyadi:fix-merge-multiple-params-and-files

Oct 17, 2023

Merged

[Form] Fix merging params & files when "multiple" is enabled#52021

nicolas-grekas merged 1 commit intosymfony:5.4frompriyadi:fix-merge-multiple-params-and-files

Oct 17, 2023

Conversation

Copy link

Contributor

priyadi commentedOct 12, 2023•
edited by OskarStark
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT

If a form field is configured with the "multiple" option, the request handler merges param values with uploaded files. However, it does not merge correctly if "multiple" is enabled.

Example:

<inputtype="file"name="param[]"/><inputtype="hidden"name="param[]"value="data1"/><inputtype="hidden"name="param[]"value="data2"/>

With the example, the file field will incorrectly replace the first hidden field, when they should be merged. This commit fixes the problem.

priyadi requested review fromxabbuh andyceruto ascode owners

October 12, 2023 17:04

carsonbot added Status: Needs Review Bug Form labels

Oct 12, 2023

carsonbot added this to the6.3 milestone

Oct 12, 2023

Copy link

carsonbot commentedOct 12, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

nicolas-grekas modified the milestones:6.3,5.4

Oct 17, 2023

nicolas-grekas changed the base branch from6.3 to5.4

October 17, 2023 11:19

nicolas-grekas requested review fromOskarStark,chalasr,dunglas andlyrixx ascode owners

October 17, 2023 11:19

[Form] Fix merging params & files when "multiple" is enabled

4da09bc

If a form field is configured with the "multiple" option, the requesthandler merges param values with uploaded files. However, it does notmerge correctly if "multiple" is enabled.Example:    <input type="file" name="param[]" />    <input type="hidden" name="param[]" value="data1" />    <input type="hidden" name="param[]" value="data2" />With the example, the file field will incorrectly replace the firsthidden field, when they should be merged. This commit fixes the problem.