NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Serializer] Add support for union collection value types in`ArrayDenormalizer`#52018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Jeroeny wants to merge2 commits intosymfony:7.4

base:7.4

Choose a base branch

fromJeroeny:mixedarray

Open

[Serializer] Add support for union collection value types in`ArrayDenormalizer`#52018

Jeroeny wants to merge2 commits intosymfony:7.4fromJeroeny:mixedarray

Conversation

Copy link

Contributor

Jeroeny commentedOct 12, 2023•
edited
Loading

Q	A
Branch?	7.2
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

Currently only the following array types combination is supported:array<MyObject>|array<Another>. This results in arrays with only 1 type of objects.

This PR aims to add support for arrays where values can be either of those, like union types:array<MyObject|Another>.

I've currently tested is successfully against the following types:

DateTimeInterface[]
array<array<DateTimeInterface|DateInterval|string>>
array<DateTimeInterface>|array<DateInterval>
array<DateTimeInterface|DateInterval>
array<DateTimeInterface|null>

Jeroeny requested a review fromdunglas as acode owner

October 12, 2023 13:17

carsonbot added the Status: Needs Review label

Oct 12, 2023

Jeroeny force-pushed themixedarray branch 5 times, most recently from3e542ae tocb066b3Compare

October 12, 2023 15:19

nicolas-grekas added this to the7.1 milestone

Oct 27, 2023

Copy link

Member

nicolas-grekas commentedApr 12, 2024

Anyone with more background on Serializer would be willing to review this PR? (note that it should target 7.1 for now, maybe 7.2 if we can't make it since we're in feature freeze now).
/cc@mtarld maybe? Anyone else?

Copy link

Contributor

mtarld commentedApr 12, 2024

As#53160 has been merged, thevalidateAndDenormalize method is now usingType of TypeInfo component, which can make this patch easier.
So, this PR has to be rebased and updated accordingly.

Add support for union collection value types inArrayDenormalizer

89e2f63

Jeroeny force-pushed themixedarray branch fromcb066b3 toe4b5202Compare

May 6, 2024 11:47

Rebase onto 7.1

514bcc2

Jeroeny force-pushed themixedarray branch frome4b5202 to514bcc2Compare

May 6, 2024 11:57

Copy link

ContributorAuthor

Jeroeny commentedMay 6, 2024

Rebased onto 7.1 and description targeting 7.2.

The newvalidateAndDenormalizeLegacy vs validateAndDenormalize` are a bit complex, so not sure yet how to apply the changes to the method using the new types.