NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Fix calling`Kernel::warmUp()` when running`cache:warmup`#51969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:fwb-warm-kernel

Oct 12, 2023

Merged

[FrameworkBundle] Fix calling`Kernel::warmUp()` when running`cache:warmup`#51969

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:fwb-warm-kernel

Oct 12, 2023

Conversation

Copy link

Member

nicolas-grekas commentedOct 10, 2023

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT

Maps to

symfony/src/Symfony/Component/HttpKernel/Kernel.php

Lines 581 to 587 ine86d26a


	$preload =$thisinstanceof WarmableInterface ? (array)$this->warmUp($this->container->getParameter('kernel.cache_dir')) : [];

	if ($this->container->has('cache_warmer')) {
	$preload =array_merge($preload, (array)$this->container->get('cache_warmer')->warmUp($this->container->getParameter('kernel.cache_dir')));
	}

carsonbot added Status: Needs Review Bug FrameworkBundle labels

Oct 10, 2023

carsonbot added this to the5.4 milestone

Oct 10, 2023

HeahDude reviewed

Oct 10, 2023

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php OutdatedShow resolvedHide resolved

[FrameworkBundle] Fix calling Kernel::warmUp() when running cache:warmup

f10c2cc

nicolas-grekas force-pushed thefwb-warm-kernel branch froma853783 tof10c2ccCompare

October 10, 2023 15:11

OskarStark changed the title~~[FrameworkBundle] Fix calling Kernel::warmUp() when running cache:warmup~~[FrameworkBundle] Fix callingKernel::warmUp() when runningcache:warmup

Oct 10, 2023

nicolas-grekas merged commit4290999 intosymfony:5.4

Oct 12, 2023

nicolas-grekas deleted the fwb-warm-kernel branch

October 16, 2023 20:21