Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle] PhpUnit assert Messenger#51964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
[FrameworkBundle] PhpUnit assert Messenger#51964
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedOct 10, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
4fa419f
to35def9d
Comparesrc/Symfony/Component/Messenger/EventListener/MessagesSentToTransportsListener.php.orig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Messenger/DummyCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Messenger/DummyQuery.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Labelling the PR as PhpUnitBridge is wrong as this adds the feature in FrameworkBundle. |
34956ed
tofbaeb1c
Comparefbaeb1c
to324586c
Comparesrc/Symfony/Bundle/FrameworkBundle/Test/MessengerAssertionsTrait.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Test/MessengerAssertionsTrait.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
09e6f34
to0398f6e
Compare* @param string|null $busName The busName to consider | ||
* @param string|null $messageFQCN The message object class name to consider | ||
*/ | ||
public static function assertMessagesCount(int $count, string $busName = null, string $messageFQCN = null, string $message = ''): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Very small suggestion : I thinkassetMessageCount
(without the 's') would be more 'correct' 😃
0398f6e
toa96e01c
Comparea96e01c
to2ed780c
Compare
Uh oh!
There was an error while loading.Please reload this page.
Hello,
This MessengerAssertionTrait is a Helper for those who want to be able to test the dispatched messages while working with Messenger.
Hope this helps!
Regards,
Marilena Ruffelaere