Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add all missing properties#51866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
y4roc wants to merge1 commit intosymfony:5.4fromy4roc:all-missing-properties

Conversation

@y4roc
Copy link

@y4rocy4roc commentedOct 6, 2023
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

Current behavior: If multiple arguments are missing in the constructor, only the first argument is listed as missing in the array.

Expected behavior: All missing arguments are listed.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedOct 6, 2023
edited
Loading

Thanks for the PR but it's missing a lot of context, proper title, PR description and tests. Can you please update it to make us able to understand where you're coming from on the topic and where you'd like to go?

OskarStark reacted with thumbs up emoji

@y4roc
Copy link
Author

I'll add a test soon.

OskarStark reacted with thumbs up emoji

@HypeMC
Copy link
Member

IMO, this is part of a slightly bigger story, see#51907

nicolas-grekas added a commit that referenced this pull requestOct 17, 2023
… argument (HypeMC)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Serializer] Fix collecting only first missing constructor argument| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MITAlternative to#51866, sort of followup to#49832Currently on 5.4 only the first exception is added to the `not_normalizable_value_exceptions` array when `COLLECT_DENORMALIZATION_ERRORS` is `true` or only the first argument is mentioned in the `MissingConstructorArgumentsException` when it is `false`.On 6.3 however, the part with the `MissingConstructorArgumentsException` was fix with#49832, but the part with the `not_normalizable_value_exceptions` was overlooked.IMO this is inconsistent behavior as the two cases are actually the same thing with the only difference being that in one case an exception is thrown while in the other the errors are collected.I'm not sure if#51866 really qualifies as a bug or is actually more a feature, but the reason#49832 was merged onto 6.3 was because of the changes originally done in#49013, which itself was a feature.If#51866 does qualify as a bug then it would make sense to backport#49832 to 5.4 for consistency, which is what this PR does.The PR contains two commits:1) backport of#498322) alternative to#51866If#51866 does not qualify as a bug, the first commit can be drooped and the second one can be rebased with 6.4.PS I think it's easier to review the changes commit by commit.Commits-------0f398ce [Serializer] Fix collecting only first missing constructor argument
@nicolas-grekas
Copy link
Member

Fixed in#51907, thanks for proposing.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@y4roc@nicolas-grekas@HypeMC@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp