Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Add type to redis scan call to avoid using default "" which r…#51838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark commentedOct 6, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I removed the deprecations label, as this does not introduce a new deprecation, but fixes one. Are you sure, this bug does not exist in 5.4? |
fabpot commentedOct 7, 2023
The code looks the same on 5.4. |
mfadul24 commentedOct 9, 2023
Hi, I've update the PR to use the 5.4 branch and add a test for this use case. I hope it looks good enough for you. Look forward to my first contribution. |
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedOct 13, 2023
Thanks for giving this a try. I'm closing in favor of#52036, which provides a more generic fix to such issues. This should still be fixed in phpredis, but at least we won't fall into the trap. |
…y behaviors of internal classes (nicolas-grekas)This PR was merged into the 6.3 branch.Discussion----------[Cache][VarExporter] Fix proxy generation to deal with edgy behaviors of internal classes| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#51770,#51679,#51700| License | MITInstead of#51838This fixes the issue by not passing default values explicitly when they were not provided during the call to the method.Commits-------c66a2f7 [Cache][VarExporter] Fix proxy generation to deal with edgy behaviors of internal classes
Uh oh!
There was an error while loading.Please reload this page.
The
cache:pool:clearcommand is not clearing the existing redis keys correctly. The method is being call without a validtype, which gets a empty array as response.The redis
MONITORcommand shows the following type of call:"SCAN" "0" "COUNT" "1000" "MATCH" "<prefix>:*" "TYPE" ""Correct would be to set the
TYPEtostring."SCAN" "0" "COUNT" "1000" "MATCH" "<prefix>:*" "TYPE" "string"See Documentation:https://redis.io/commands/type/
This PullRequest also fix the deprecation:
Deprecated: Redis::scan(): Passing null to parameter #4 ($type) of type ?string is deprecated {"exception":"[object] (ErrorException(code: 0): Deprecated: Redis::scan(): Passing null to parameter #4 ($type) of type ?string is deprecated at /var/www/vendor/symfony/cache/Traits/Redis6Proxy.php:893)"