I am not convinced that a MAC address validator is a common enough use case to be included in the Symfony core.

Thanks for the PR. Here are some comments. Changing the defaults look undesired to me since it would change the behavior of existing apps without notice. Can you also please update the title of your PR so that it can be useful for readers in the auto-generated changelog when doing the release?

Thx for review, merged your commits, reverted your comments & changed title :-)

If we want to change the default version, we would have to make it configurable in the validator:

• make theversion field of the constraint nullable and default tonull
• configure a default version in the validator (defaulting toV4 for BC reasons), that is used when the constraint version isnull
• add a configuration setting in FrameworkBundle to configure the default IP version.

But to me, this deserves a separate PR than this one adding new version constants. It deserves to have a separate discussion instead of being bundled in the same decision to merge or no (note that I would have separated the Mac constraint as well, to allow separating the decisions as well).

Seems my responses are still on pending... I'll reply as seperate comment:

I used the same suffix, which was used as filter flag (e.g.FILTER_FLAG_NO_PRIV_RANGE, see also:https://www.php.net/manual/de/filter.filters.flags.php).

Also this constraint already contains constants with_PRIV &_RES suffix, see already existing constant*_ONLY_PRIV:
https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/Validator/Constraints/Ip.php#L35

We cannot just rename new constants toPRIVATE orRESERVED, this will be inconsistent. We could also rename old constrants to new suffix, but then we need to add additional complexity for backward-compatibility...

We cannot just rename new constants toPRIVATE orRESERVED, this will be inconsistent. We could also rename old constants to new suffix, but then we need to add additional complexity for backward-compatibility...

@nicolas-grekas suggested to duplicate all names in his latest comment.

@Seb33300@nicolas-grekas@OskarStark renamed & deprecated old constants. Hope it's fine now :-)

I've also updatedCidr constraint to use possible versions defined inIp constraint. Please check also :-)

(please rebase, don't merge - you can also squash as we won't keep the history)

(please rebase, don't merge - you can also squash as we won't keep the history)

Ok now I have a problem.. :D Give me some min, may I'll create a new branch if possible to retag this MR :/

@nicolas-grekas I've created a new branch based on 7.1, hope this is fine :( Sry for spamming, I'll try to rebase my mac addresses branch instead :)

See also:#52658