Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update the design of the Symfony Welcome Page#51771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.0fromjaviereguiluz:new_welcome_page
Oct 5, 2023

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluzjaviereguiluz commentedSep 28, 2023
edited
Loading

QA
Branch?7.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT

This PR refreshes the design of the Symfony Welcome Page for Symfony 7.0. This is the page that you see when you create a new Symfony app and browse it without making any change to it.

The new design keeps most of the features of the previous design, including the random color each time you reload the page.

This is how it looks:

SmartphoneTabletDesktop
new-welcome-page-smartphonenew-welcome-page-tabletnew-welcome-page-desktop

This is how it lookedbefore:

SmartphoneTabletDesktop
before-welcome-page-smartphonebefore-welcome-page-tabletbefore-welcome-page-desktop

maxbeckers, evertharmeling, smnandre, COil, SzymonKaminski, moulayecisse, GromNaN, skmedix, ker0x, Nyholm, and 10 more reacted with thumbs up emojisstok, OskarStark, MGDSoft, yceruto, hhamon, and Jubeki reacted with heart emojiantonkomarev reacted with eyes emoji
@antonkomarev
Copy link

It will be great to add screenshots how it looks like right now.

@javiereguiluz
Copy link
MemberAuthor

@antonkomarev I've updated the PR to include the before screenshots.

GromNaN reacted with thumbs up emoji

@evertharmeling
Copy link
Contributor

Nice! Could we maybe use more specific icons instead of checkmarks for the 3 main bullet points? Something like:

  • Atag for the version
  • Adirectory for the path
  • Aterminal (could not a find a specific icon for debug :)) for the debug mode

The list contains 'important' information and I feel it's easily to not read them because it's just another list of bullet points.

javiereguiluz reacted with thumbs up emoji

@smnandre
Copy link
Member

Really nice and clean.

I'd suggest separating the 3 factual (& positive-ish) elements from the item requiring user action

--

✅ You are using Symfony XXX version
✅ Your application is ready at XXX
✅ Debug mode is activated

❓ Your homepage is not configured: create your first page.

--

I have a feeling that more people will wonder, 'cool, it works, what do I do now?' than 'why is this page displayed?'... but with no certitude.

javiereguiluz reacted with thumbs up emoji

@antonkomarev
Copy link

Good point, but I suggest having a warning sign near the debug mode:
⚠️ Debug mode is activated

evertharmeling reacted with thumbs up emoji

@javiereguiluz
Copy link
MemberAuthor

javiereguiluz commentedSep 28, 2023
edited
Loading

Thank you all for your nice reviews. I'm going to iterate over some of these ideas and will come back with an update.

@derrabus
Copy link
Member

Since we usually don't merge features into x.0 releases, what's preventing us from merging this into 6.4?

@stof
Copy link
Member

I tend to agree with@derrabus here. We communicate regularly than the X.4 releases contains all the new features and Y.0 cleans the deprecated APIs. So this should go in 6.4.

antonkomarev, 94noni, and OskarStark reacted with thumbs up emoji

@javiereguiluz
Copy link
MemberAuthor

javiereguiluz commentedSep 28, 2023
edited
Loading

@derrabus@stof this is the classic "engineering vs product" problem.

Engineering team says that new features must go to 6.4 because X.0 branches don't get new features.

But for Product team it's important that this new design is only visible in Symfony 7.0 and up, because this is the new design for Symfony 7, not Symfony 6.4 and 7.


Personally, I'd make an exception here and merge this into 7.0 only. But I'll do what the team decides 🙏 Thanks!

@94noni
Copy link
Contributor

94noni commentedSep 28, 2023
edited
Loading

the previous PR updating the design was done onv4.4+v5.0
it would be nice to keep same logic (moreover as .4 are LTS so displayed during long time after initial release)

@fabpot
Copy link
Member

7.0 sounds fine to me (it's not "a feature" per se but more like a refresh of the design for a major version).

OskarStark reacted with thumbs up emoji

@MGDSoft
Copy link
Contributor

What are your thoughts on adding a subtle motion effect to the stars and water?

sstok reacted with thumbs down emoji

@sstok
Copy link
Contributor

What are your thoughts on adding a subtle motion effect to the stars and water?

Motion effects don't add anything useful here, and might cause trouble on the front of accessibility as movement can cause motion sickness for people with motion sensitivity.

https://www.linkedin.com/advice/0/how-do-you-avoid-animation-overload-motion

MGDSoft reacted with confused emoji

@MGDSoft
Copy link
Contributor

What are your thoughts on adding a subtle motion effect to the stars and water?

Motion effects don't add anything useful here, and might cause trouble on the front of accessibility as movement can cause motion sickness for people with motion sensitivity.

https://www.linkedin.com/advice/0/how-do-you-avoid-animation-overload-motion

Well, then, 50% of webpages have motion on their homepage, and they are all incorrect.

https://laravel.com/
https://nextjs.org/
https://www.meteor.com/

I believe adding some effects will generate more excitement for newcomers interested in learning Symfony. For example, when I install Drupal, I encounter an unattractive default page that prompts me to leave quickly.

javiereguiluz reacted with thumbs up emoji

@fabpot
Copy link
Member

The current page is animated, right? So, I suppose the new version will be as well.

sstok reacted with laugh emoji

@MGDSoft
Copy link
Contributor

MGDSoft commentedOct 2, 2023
edited
Loading

The current page is animated, right? So, I suppose the new version will be as well.

If I'm correct,@javiereguiluz, I didn't notice any effect on the page; I only saw the background color change (which is cool).

javiereguiluz reacted with thumbs up emoji

@smnandre
Copy link
Member

@media (prefers-reduced-motion) {/* styles to apply if a user's device settings are set to reduced motion */}

I believe animation is not a problem if we leverage this media query

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

MGDSoft and sstok reacted with heart emoji

@MGDSoft
Copy link
Contributor

MGDSoft commentedOct 2, 2023
edited
Loading

It's just an idea but something like this, We can do better, of course, if everyone agrees.

Recording.2023-10-02.235807.mp4
yceruto reacted with heart emoji

@javiereguiluz
Copy link
MemberAuthor

@MGDSoft can you please share the CSS code that you used to add that subtle animation? Thanks!

@MGDSoft
Copy link
Contributor

MGDSoft commentedOct 3, 2023
edited
Loading

ofc!

Waves (SVG is the same)

functionrenderWavesSvg(){return<<<SVG<svgaria-hidden="true"focusable="false"style="pointer-events: none"class="wave"width="100%"height="50px"preserveAspectRatio="none"xmlns="http://www.w3.org/2000/svg"xmlns:xlink="http://www.w3.org/1999/xlink"viewBox="0 0 1920 75"><defs><style>                .a{fill:none}.b{clip-path:url(#a)}.c,.d{fill:var(--light-color);}.d{opacity:0.5;isolation:isolate;}                @keyframes waveMotion{0%{transform:scaleX(1)translateX(0);}50%{transform:scaleX(1.5)translateX(-30%);}0%{transform:scaleX(1)translateX(0);}}                .b:nth-child(5){animation:waveMotion10sinfinitealternate;}                                .b:nth-child(2){animation:waveMotion8sinfinitealternate;}                                .b:nth-child(3){animation:waveMotion9sinfinitealternate;}                                .b:nth-child(4){animation:waveMotion4sinfinitealternate;}</style><clipPathid="a"><rectclass="a"width="1920"height="75"></rect></clipPath></defs><gclass="b"><pathclass="c"d="M1963,327H-105V65A2647.49,2647.49,0,0,1,431,19c217.7,3.5,239.6,30.8,470,36,297.3,6.7,367.5-36.2,642-28a2511.41,2511.41,0,0,1,420,48"></path></g><gclass="b"><pathclass="d"d="M-127,404H1963V44c-140.1-28-343.3-46.7-566,22-75.5,23.3-118.5,45.9-162,64-48.6,20.2-404.7,128-784,0C355.2,97.7,341.6,78.3,235,50,86.6,10.6-41.8,6.9-127,10"></path></g><gclass="b"><pathclass="d"d="M1979,462-155,446V106C251.8,20.2,576.6,15.9,805,30c167.4,10.3,322.3,32.9,680,56,207,13.4,378,20.3,494,24"></path></g><gclass="b"><pathclass="d"d="M1998,484H-243V100c445.8,26.8,794.2-4.1,1035-39,141-20.4,231.1-40.1,378-45,349.6-11.6,636.7,73.8,828,150"></path></g></svg>SVG;}

STARS

@keyframes stars{0% {transform:translateX(0)translateY(0px);    }33% {transform:translateX(-20px)translateY(-20px);    }66% {transform:translateX(-40px)translateY(-40px);    }100% {transform:translateX(0px)translateY(0px);    }}header:after {animation: stars15s infinite;}
javiereguiluz, Crovitche-1623, yceruto, and suasgn reacted with thumbs up emojievertharmeling and sstok reacted with rocket emoji

@javiereguiluz
Copy link
MemberAuthor

javiereguiluz commentedOct 3, 2023
edited
Loading

Thank you all for your reviews. I've made these changes:

  • Use different icons in the list of items
  • Separate the "What do do next?" item and turned it into "Next Step"
  • Added the nice animation proposed by@MGDSoft (thanks!) but I made it slower to make it more subtle
  • Added a slight blur to stars to increase readability

This is how it looks now:

SmartphoneTabletDesktop
smartphonetabletdesktop

And this is in movement:

animation.mp4
MGDSoft, yceruto, evertharmeling, SVillette, suasgn, birkof, and gquemener reacted with heart emojiMGDSoft, yceruto, and evertharmeling reacted with rocket emoji

@yceruto
Copy link
Member

I love these improvements! ❤️

javiereguiluz and sstok reacted with heart emoji

@yceruto
Copy link
Member

On a wide screen, it looks great, but perhaps on mobile we should add more space between texts as it looks a bit cramped.

@smnandre
Copy link
Member

Love it, thx@javiereguiluz for this!

javiereguiluz and sstok reacted with heart emoji

@javiereguiluz
Copy link
MemberAuthor

I've tweaked some margins/paddings/spacing as requested. Thanks.

evertharmeling, hhamon, and yceruto reacted with hooray emojievertharmeling, hhamon, and yceruto reacted with heart emojievertharmeling, yceruto, and sstok reacted with rocket emoji

@fabpot
Copy link
Member

Thank you@javiereguiluz.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@AweptimumAweptimumAweptimum left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

13 participants

@javiereguiluz@antonkomarev@evertharmeling@smnandre@derrabus@stof@94noni@fabpot@MGDSoft@sstok@yceruto@Aweptimum@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp