Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] NoSuspiciousCharacters custom error messages fix#51726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@bam1to
Copy link
Contributor

QA
Branch?6.3 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#51715
LicenseMIT
Doc PR

We use the ?? operator to check if the entered constructor arguments are equal to null. The previous operator (??=) was incorrect because of the default messages' values.

MatTheCat reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@bam1tobam1to changed the base branch from6.4 to6.3September 22, 2023 20:41
@derrabusderrabus modified the milestones:6.4,6.3Sep 25, 2023
@carsonbotcarsonbot changed the titleNoSuspiciousCharacters custom error messages fix[Validator] NoSuspiciousCharacters custom error messages fixSep 25, 2023
@derrabus
Copy link
Member

Thank you. Can you provide a test for this issue?

@nicolas-grekas
Copy link
Member

Thank you@bam1to.

bam1to reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitf47f589 intosymfony:6.3Sep 27, 2023
@fabpotfabpot mentioned this pull requestSep 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

NoSuspiciousCharacters constraint doesn't allow to change the error messages

6 participants

@bam1to@carsonbot@derrabus@nicolas-grekas@javiereguiluz@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp