Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DeprecateKernel::stripComments()#51712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alamirault
Copy link
Contributor

@alamiraultalamirault commentedSep 21, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

This PR replacemethod_exists byclass_exists in order to check if component is available. It harmonize codebase

This PR remove checking if methodKernel::setIgnore exists.

This method was introduced in symfony 2.3 (#18048), so now it's always available

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The DI component can be used without the HttpKernel component, so this check is still relevant!

@alamirault
Copy link
ContributorAuthor

Hum, I understand now !
But shouldn't we useclass_exists instead ? Like is done in codebase ?

@derrabus
Copy link
Member

We could do that, yes.

@stof
Copy link
Member

given that this method is not used anywhere in the HttpKernel component and does not depend on anything else in the component (its only dependency istoken_get_all), maybe we should copy it in the PhpDumper of the DI component as a private method and deprecate the Kernel method.

alamirault, derrabus, and GromNaN reacted with heart emoji

@alamiraultalamiraultforce-pushed thefeature/remove-method-exists-Kernel-stripComments branch from148a7fe to4b7bdd6CompareSeptember 22, 2023 17:04
@alamiraultalamirault changed the title[DependencyInjection] Remove checking if Kernel stripComment` method exists[DependencyInjection] DeprecateKernel::stripComments()Sep 22, 2023
@alamiraultalamirault changed the title[DependencyInjection] DeprecateKernel::stripComments()[HttpKernel] DeprecateKernel::stripComments()Sep 22, 2023
@alamirault
Copy link
ContributorAuthor

I deprecated method inKernel and created a private inPhpDumper

@carsonbotcarsonbot changed the title[HttpKernel] DeprecateKernel::stripComments()DeprecateKernel::stripComments()Sep 23, 2023
@fabpotfabpotforce-pushed thefeature/remove-method-exists-Kernel-stripComments branch from15ac150 to43c5038CompareSeptember 24, 2023 12:10
@fabpot
Copy link
Member

Thank you@alamirault.

@fabpotfabpot merged commit0d344e1 intosymfony:6.4Sep 24, 2023
@alamiraultalamirault deleted the feature/remove-method-exists-Kernel-stripComments branchSeptember 24, 2023 18:39
@nicolas-grekasnicolas-grekas added this to the6.4 milestoneSep 25, 2023
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

6 participants

@alamirault@derrabus@stof@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp