NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translation] Give current locale to`LocaleSwitcher::runWithLocale()`'s callback#51684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromalexander-schranz:feature/local-switcher-locale

Sep 20, 2023

Merged

[Translation] Give current locale to`LocaleSwitcher::runWithLocale()`'s callback#51684

nicolas-grekas merged 1 commit intosymfony:6.4fromalexander-schranz:feature/local-switcher-locale

Sep 20, 2023

Conversation

Copy link

Contributor

alexander-schranz commentedSep 18, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix #...
License	MIT
Doc PR	symfony/symfony-docs#...

I think it would not hurt to give the $locale everytime to the callback method.

Example usage:

$notificationContent =$this->localeSwitcher->runWithLocale($contact->getLocale(),function(string$locale)use ($someEntity):string {$title =$someEntity->getTitle($locale);return$this->twig->render('template.html.twig', ['title' =>$title]);});

Alternative solution currently is:

$locale =$contact->getLocale();$notificationContent =$this->localeSwitcher->runWithLocale($locale,function()use ($locale,$someEntity):string {$title =$someEntity->getTitle($locale);return$this->twig->render('template.html.twig', ['title' =>$title]);});

So this avoids creating a$locale variable which maybe only is necessary inside the callback method.

alexander-schranz requested a review fromwelcoMattic as acode owner

September 18, 2023 15:43

stof approved these changes

Sep 19, 2023

View reviewed changes

nicolas-grekas added Translation Feature labels

Sep 19, 2023

nicolas-grekas approved these changes

Sep 19, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a line in the changelog :)

welcoMattic approved these changes

Sep 20, 2023

View reviewed changes

welcoMattic changed the title~~Give current locale to locale switcher runWithLocale callback~~[Translation] Give current locale to locale switcher runWithLocale callback

Sep 20, 2023

welcoMattic added the Status: Reviewed label

Sep 20, 2023

nicolas-grekas changed the title~~[Translation] Give current locale to locale switcher runWithLocale callback~~[Translation] Give current locale toLocaleSwitcher::runWithLocale()'s callback

Sep 20, 2023