Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Fix support for Redis Sentinel using php-redis 6.0.0#51683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| 'host' =>$host, | ||
| 'port' =>$port, | ||
| 'connectTimeout' =>$params['timeout'], | ||
| 'persistent' =>$params['persistent_id'], |
QonstruktSep 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is noconnect orpconnect call usingRedisSentinel. So the decision of being persistent or not is being take by this value beingnull or set to astring. Not sure why it was converted tostring before, but this works perfectly fine on my environment (without persistence) at least.
Uh oh!
There was an error while loading.Please reload this page.
47c3103 to91bcc05Compare91bcc05 to9423c71Comparenicolas-grekas commentedSep 19, 2023
Thank you@Qonstrukt. |
This PR was merged into the 6.4 branch.Discussion----------[Cache] Fix two initializations of Redis Sentinel| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | n/a| License | MITAfter#51687 and#51683 have been merged, there are now two initializations of Redis Sentinel, which also leads to the integration test failure mentioned in [this comment](#51687 (comment)). This PR fixes this.Commits-------2d23a1b [Cache] Fix two initializations of Redis Sentinel
… 6.0.0 (pepeh)This PR was squashed before being merged into the 6.3 branch.Discussion----------[Messenger] Fix support for Redis Sentinel using php-redis 6.0.0| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#52487| License | MITAdded support for [php-redis 6.0.0](https://github.com/phpredis/phpredis/blob/develop/CHANGELOG.md#600---2023-09-09-github-pecl) to Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.A similar fix was done for RedisTrait before:#51683Commits-------42a80db [Messenger] Fix support for Redis Sentinel using php-redis 6.0.0
Uh oh!
There was an error while loading.Please reload this page.
Added support forphp-redis 6.0.0 to
Symfony/Component/Cache/Traits/RedisTrait.Made changes to how
RedisSentinelis constructed, which now usesthe same constructor as the mainRedisclass. Didn't find any other changes that might be relevant yet, but it's why I mention Redis Sentinel explicitly.