Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix support fortranslator.default_path in XML#51671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
default_path in XMLdefault_path in XMLjaviereguiluz approved these changesSep 19, 2023
default_path in XMLtranslator.default_path in XMLtranslator.default_path in XMLtranslator.default_path in XMLMember
nicolas-grekas commentedSep 19, 2023
Thank you@HeahDude. |
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestSep 19, 2023
This PR was merged into the 5.4 branch.Discussion----------[Translation] Fix `default-path` XML configNote: we should wait forsymfony/symfony#51671 to be merged first.Commits-------8f381f6 [Translator] Fix `default-path` XML config
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs is currently wrong assuming there is an element
default-pathusing XML config,https://symfony.com/doc/current/translation.html#configuration.It appears it's missing in the XSD, but IMO it should be added as an attribute.