Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Fix Smsmode HttpClient mandatory headers#51629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3frominwebo:bugfix/SmsmodeTransport
Sep 19, 2023

Conversation

@inwebo
Copy link
Contributor

@inweboinwebo commentedSep 11, 2023
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
Ticketsno
LicenseMIT
Doc PRsymfony/symfony-docs#...

As mentioned in the documentationhttps://dev.smsmode.com/sms/v1/home in section Content-Type & URL Encoding.

HTTP request and response bodies are JSON objects, which is why Accept and Content-Type headers are mandatory and are implicitly added when the request is executed with the TEST button. If the Accept header is missing, a Not Acceptable (406) HTTP status code is returned. (Accept: application/json) The Content-Type header is only needed with POST and PATCH methods. If it is missing, an Unsupported Media Type (415)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabus
Copy link
Member

Thank you. Please add a test.

OskarStark and inwebo reacted with thumbs up emoji

@derrabusderrabus added the Bug labelSep 11, 2023
@inweboinweboforce-pushed thebugfix/SmsmodeTransport branch fromc2f3631 to1ed73feCompareSeptember 12, 2023 07:02
@inwebo
Copy link
ContributorAuthor

Hello,

I need help there, i don't get it why my simple PR is failing with Redis extension relay tests.

Regards

@nicolas-grekas
Copy link
Member

i don't get it why my simple PR is failing with Redis extension relay tests.

It's unrelated, you can ignore these failures and focus on your changes.

inwebo reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@inwebo.

inwebo reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commita99b697 intosymfony:6.3Sep 19, 2023
@fabpotfabpot mentioned this pull requestSep 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@inwebo@carsonbot@derrabus@nicolas-grekas@stof

[8]ページ先頭

©2009-2025 Movatter.jp