Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Fix Smsmode HttpClient mandatory headers#51629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedSep 11, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
derrabus commentedSep 11, 2023
Thank you. Please add a test. |
c2f3631 to1ed73feCompareinwebo commentedSep 12, 2023
Hello, I need help there, i don't get it why my simple PR is failing with Redis extension relay tests. Regards |
src/Symfony/Component/Notifier/Bridge/Smsmode/SmsmodeTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/Smsmode/Tests/SmsmodeTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedSep 12, 2023
It's unrelated, you can ignore these failures and focus on your changes. |
813c1d5 toa3dd8dcComparenicolas-grekas commentedSep 19, 2023
Thank you@inwebo. |
Uh oh!
There was an error while loading.Please reload this page.
As mentioned in the documentationhttps://dev.smsmode.com/sms/v1/home in section Content-Type & URL Encoding.
HTTP request and response bodies are JSON objects, which is why Accept and Content-Type headers are mandatory and are implicitly added when the request is executed with the TEST button. If the Accept header is missing, a Not Acceptable (406) HTTP status code is returned. (Accept: application/json) The Content-Type header is only needed with POST and PATCH methods. If it is missing, an Unsupported Media Type (415)