Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge][TwigBundle] Drop support for Twig 2#51626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The changelog file must be updated
Uh oh!
There was an error while loading.Please reload this page.
derrabus commentedSep 11, 2023
Done for TwigBundle and TwigBridge. Not sure if I need to do that for the other bundles/components as well. |
stof commentedSep 11, 2023
@derrabus I think it is OK as is. |
| "symfony/process":"^6.4|^7.0", | ||
| "symfony/uid":"^6.4|^7.0", | ||
| "twig/twig":"^2.13|^3.0.4" | ||
| "twig/twig":"^3.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should this add the conflict rule ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure. It didn't have one before and I don't know why that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code that depends on twig is very robust.
| if (!empty($f['class']) && (is_subclass_of($f['class'],'Twig\Template') ||is_subclass_of($f['class'],'Twig_Template')) &&method_exists($f['class'],'getDebugInfo')) { |
nicolas-grekas commentedSep 11, 2023
Thank you@derrabus. |
Let's make our lives easier and only support one major version of Twig in the future. Upgrading projects from Twig 2 to 3 shouldn't be much trouble anyway.