Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[CI] Make tests green again#51622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromvtsykun:fix/tests-green
Sep 12, 2023

Conversation

@vtsykun
Copy link
Contributor

@vtsykunvtsykun commentedSep 11, 2023•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

@carsonbotcarsonbot added this to the6.4 milestoneSep 11, 2023
@vtsykunvtsykun changed the titleMake tests green again[CI] Make tests green againSep 11, 2023
@vtsykunvtsykunforce-pushed thefix/tests-green branch 2 times, most recently fromf3bf778 tob7114c7CompareSeptember 11, 2023 02:01
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR. It seams to include more than "make CI green". Or am I wrong?

return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bitcount(...\func_get_args());
}

publicfunctionbitfield($key, ...$args):\Relay\Relay|array|false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hm.. why was this method added?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The testSymfony\Component\Cache\Tests\Traits\RedisProxiesTest::testRelayProxyfailed after update php extensionext-relay, just I sync proxy trait with latest changes ofRelay\Relay class

derrabus reacted with thumbs up emoji
nicolas-grekas added a commit that referenced this pull requestSep 11, 2023
This PR was merged into the 6.3 branch.Discussion----------[Security] Fix security tests| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Follows#51622| License       | MIT| Doc PR        | -Related to issue#51104, after it security bundle at least requires `symfony/security-http:6.3.4`  to keep the tests is greenCommits-------26cff6c Fix security tests
@vtsykun
Copy link
ContributorAuthor

@nicolas-grekasnicolas-grekas modified the milestones:6.4,6.3Sep 12, 2023
@nicolas-grekas
Copy link
Member

Thank you@vtsykun.

@nicolas-grekasnicolas-grekas merged commit469a143 intosymfony:6.4Sep 12, 2023
@nicolas-grekas
Copy link
Member

(I cherry-picked the changes that applied to 5.4 and 6.3 respectively)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@NyholmNyholmNyholm requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasr

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@vtsykun@nicolas-grekas@Nyholm@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp