Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Allow to add some headers as a strings#51601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromOipnet:6.4
Sep 20, 2023

Conversation

Oipnet
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
TicketsFix#51584
LicenseMIT

When adding a MailboxListHeader header, the constructor expects an array as parameter.

To simplify the UX, we now allow you to pass a string to the addHeader method in the case of a MailBoxListHeader. The header value is then converted to an array.

sc0rp10 reacted with thumbs up emoji
@carsonbotcarsonbot added this to the6.4 milestoneSep 8, 2023
@xabbuhxabbuh added the Mime labelSep 12, 2023
@carsonbotcarsonbot changed the titlesymfony/mime does not allow to add some headers as a strings[Mime] symfony/mime does not allow to add some headers as a stringsSep 12, 2023
@derrabus
Copy link
Member

derrabus commentedSep 13, 2023•
edited
Loading

Thank you.

We don't allow merge commits. Please perform a rebase and squash your commits.

@AurelienPillevesse
Copy link
Contributor

AurelienPillevesse commentedSep 14, 2023•
edited
Loading

In addition to the !is_array verification, verifying that it's a string should be added no?
What do you think about it ?

@Oipnet
Copy link
ContributorAuthor

@AurelienPillevesse

When something other than a string is passed, the message seems rather explicit.

Argument#2 ($value) must be of type string, DateTime given

What do you think should happen if you don't have a string?

@derrabus
Copy link
Member

When something other than a string is passed, the message seems rather explicit.

Argument#2 ($value) must be of type string, DateTime given

This is fine, I think.

AurelienPillevesse reacted with thumbs up emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you please update the PR title (+ commit title) so that it's turned into a positive sentence about what this does?

@OipnetOipnet changed the title[Mime] symfony/mime does not allow to add some headers as a strings[Mime] Allow to add some headers as a stringsSep 19, 2023
@nicolas-grekas
Copy link
Member

Thank you@Oipnet.

sc0rp10 reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit18685c4 intosymfony:6.4Sep 20, 2023
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@derrabusderrabusderrabus approved these changes

@maxbeckersmaxbeckersmaxbeckers approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

symfony/mime does not allow to add some headers as a strings, only as arrays
7 participants
@Oipnet@derrabus@AurelienPillevesse@nicolas-grekas@maxbeckers@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp