Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add the--all option to themessenger:failed:remove command#51593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Add the--all option to themessenger:failed:remove command#51593
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9b7cbd9 to0c6d6e1Comparesrc/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
0c6d6e1 to12d9ad0Comparealexandre-daubois commentedSep 18, 2023
All comments addressed, thanks! 🙂 |
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
12d9ad0 todbed1a9Comparealexandre-daubois commentedSep 19, 2023
Addressed all your comments Nicolas, thank you! |
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
f26d36b tob674207CompareUh oh!
There was an error while loading.Please reload this page.
b674207 to1ed3feaComparesrc/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
7d62d21 to322d892Compare322d892 tod1d39c0Comparenicolas-grekas commentedSep 29, 2023
Thank you@alexandre-daubois. |
Uh oh!
There was an error while loading.Please reload this page.
We have a development server (which we don't have direct access to the database). As this server serves as a test for our devs, error messages can accumulate in our failure transport. We wanted to use the
messenger:failed:removecommand to remove them, but unfortunately, we must provide ids individually. This is problematic as we have several hundreds of failed messages.This PR adds the
--alloption to the command. This optionmust be used with the--forceoption (juste likedoctrine:schema:update --forceactually) to work. Example output:As you can see, you can of course still use the
--show-messagesoption jointly.