NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Always use buildDir as`ConfigBuilderGenerator` outputDir#51588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:fix-configbuildercachewarmer-outputdir

Sep 27, 2023

Merged

[FrameworkBundle] Always use buildDir as`ConfigBuilderGenerator` outputDir#51588

nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:fix-configbuildercachewarmer-outputdir

Sep 27, 2023

Conversation

Copy link

Member

HypeMC commentedSep 6, 2023

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#51582
License	MIT
Doc PR	-

TheConfigBuilderGenerator is instantiated in three places, two of which usekernel.build_dir as the output dir, and one which useskernel.cache_dir:

symfony/src/Symfony/Component/HttpKernel/Kernel.php
Line 736 in29f427f
newPhpFileLoader($container,$locator,$env,class_exists(ConfigBuilderGenerator::class) ?newConfigBuilderGenerator($this->getBuildDir()) :null),

symfony/src/Symfony/Component/DependencyInjection/Extension/ExtensionTrait.php

Lines 55 to 61 in29f427f

	$buildDir =$container->getParameter('kernel.build_dir');
	$locator =newFileLocator();
	$resolver =newLoaderResolver([
	newXmlFileLoader($container,$locator,$env),
	newYamlFileLoader($container,$locator,$env),
	newIniFileLoader($container,$locator,$env),
	newPhpFileLoader($container,$locator,$env,newConfigBuilderGenerator($buildDir)),

symfony/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
Lines 43 to 45 in29f427f
publicfunctionwarmUp(string$cacheDir):array
{
$generator =newConfigBuilderGenerator($cacheDir);