Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Add badge resolution to profiler#51585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Jean-Beru
Copy link
Contributor

@Jean-BeruJean-Beru commentedSep 6, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets#36668
LicenseMIT
Doc PR

This PR add badges resolution status in Security profiler as mentioned in#36668 (" See which badges are resolved and which aren't").

CSRF error

image

Wrong credentials

image

Authentication successful

image

Spomky, David-Moisan, OskarStark, kaznovac, and andreybolonin reacted with thumbs up emoji
@carsonbotcarsonbot added Status: Needs Review DXDX = Developer eXperience (anything that improves the experience of using Symfony) Feature Security labelsSep 6, 2023
@carsonbotcarsonbot added this to the6.4 milestoneSep 6, 2023
@carsonbotcarsonbot changed the title[DX][Security] Add badge resolution to profiler[Security] Add badge resolution to profilerSep 6, 2023
@fabpot
Copy link
Member

Thank you@Jean-Beru.

@fabpotfabpotforce-pushed thefeature/add-badge-resolution-to-profiler branch from3a810c1 to2324da2CompareSeptember 10, 2023 09:07
@fabpotfabpot merged commitfee9b30 intosymfony:6.4Sep 10, 2023
@PhilETaylor
Copy link
Contributor

Composer updated a stable project and now broken :(

ScreenShot-2023-09-10-15 26 32

@PhilETaylor
Copy link
Contributor

ok on debugging I can see that on the login request, when viewed In debugger, I can see the badges - so the point of this PR is working fine.

But after login when redirected to the user dashboard of the app, and trying to load any page when already logged in, then the passport is null in the TraceableAuthenticator and this means the whole app is down with the error previously provided.

Changing$this->passport->getBadges() to$this->passport?->getBadges() ?? [] suppresses the error

ScreenShot-2023-09-10-15 48 36

@chalasr
Copy link
Member

Would you mind sending a PR (with test ideally)?

@PhilETaylor
Copy link
Contributor

like this#51612 ?

fabpot added a commit that referenced this pull requestSep 10, 2023
…th (PhilETaylor)This PR was merged into the 6.4 branch.Discussion----------[Security] Fix for TraceableAuthenticator debug when no Auth| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#51585 (comment)| License       | MITFixes regression in PR#51585 and adds unit test![image](https://github.com/symfony/symfony/assets/400092/8645c3c4-1827-4dce-83b6-a1cdace8dfb1)Commits-------a9d36a5 Fix for TraceableAuthenticator debug when no Auth
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@94noni94noni94noni left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Labels
DXDX = Developer eXperience (anything that improves the experience of using Symfony)FeatureSecurityStatus: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@Jean-Beru@fabpot@PhilETaylor@chalasr@94noni@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp