NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DoctrineBridge] Add`message` to #[MapEntity] for NotFoundHttpException#51562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.1frommoesoha:doctrine-bridge/MapEntity/message

Feb 2, 2024

Merged

[DoctrineBridge] Add`message` to #[MapEntity] for NotFoundHttpException#51562

fabpot merged 1 commit intosymfony:7.1frommoesoha:doctrine-bridge/MapEntity/message

Feb 2, 2024

Conversation

Copy link

Contributor

moesoha commentedSep 5, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	N/A

Allow the message in NotFoundHttpException to be overridden with themessage argument in#[MapEntity].

[DoctrineBridge] Addmessage to #[MapEntity] for NotFoundHttpException

753ad20

carsonbot added Status: Needs Review DoctrineBridge Feature labels

Sep 5, 2023

carsonbot added this to the6.4 milestone

Sep 5, 2023

Copy link

Contributor

ro0NL commentedSep 5, 2023

this wont be displayed in prod is it? ref#49653 +#49687

Copy link

Member

derrabus commentedSep 5, 2023

Right, it won't. This message would be purely for development. I'm not saying, we shouldn't merge it, but I'm curious about the motivation behind this change.

Copy link

ContributorAuthor

moesoha commentedSep 5, 2023

I am exposing message in NotFoundHttpException to the user for a friendly 404 message in my project. This is inspired by the parameter in#[IsGranted].